fix: restore write encoding perf by encoding vectors before transform - #266
Merged
Merged
Conversation
rkruze
changed the title
benesch
approved these changes
Sep 23, 2026
benesch
left a comment
benesch
left a comment
Contributor
There was a problem hiding this comment.
Ugh, sorry, thanks. Python is so damn slow.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#259 moved vector base64 encoding into a second pass after _turbopuffer_transform. The walk then went into every vector and made one Python call per float, only to have the result base64-encoded right after. For 1000 rows x 1536 dims, transform time went from ~8ms (2.8.0) to ~105ms (2.9.0+).