Pypy2 bugfixes - #26
Open
JedMeister wants to merge 10 commits into
Open
Conversation
OnGle
approved these changes
Aug 18, 2026
OnGle
left a comment
OnGle
left a comment
Member
There was a problem hiding this comment.
Wow, that's a lot. Looks good to me though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for numerous bugs that surfaced running on pypy2.
Some are bugs already fixed in the code in one place, but not in another.
Some are oversights/unaddressed details related to the migration to default Debian duplicity and boto packages.
Most of the others could be considered "land mine" bugs. They have mostly existed for years - just hadn't surfaced prior because of undocumented quirks of the cpython2 implementation that are not explicitly part of python standard. They may or many have have come to light under python3. Regardless if nothing else they are "correctness" issues...
Also, there are lots of additional comments and new functions/methods added mostly have pretty good docstrings.
I do still have a couple of things to test but IMO this is good to review. If there is anything additional, I'll push and ping for follow up review of new code.