Make QuerySizeValidator's combined-limit case reachable; add docs - #879
Merged
Conversation
The depth && width case was ordered after the individual limit cases, so "Query is too complex" could never be reported. Reorder the cases, cover all three failure branches with tests, add Scaladoc, and add a "Compiler Phases" tutorial page showing how to enable the validator via compilerPhases.
milessabin
requested changes
Jul 26, 2026
milessabin
left a comment
milessabin
left a comment
Member
There was a problem hiding this comment.
LGTM, but could you fix the header/fmt issues. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The depth && width case was ordered after the individual limit cases, so "Query is too complex" could never be reported. Reorder the cases, cover all three failure branches with tests, add Scaladoc, and add a "Compiler Phases" tutorial page showing how to enable the validator via compilerPhases.