Skip to content

fix: correct synonym_sets type from List[List[str]] to List[str]#137

Open
santichausis wants to merge 1 commit into
typesense:masterfrom
santichausis:fix/synonym-sets-type
Open

fix: correct synonym_sets type from List[List[str]] to List[str]#137
santichausis wants to merge 1 commit into
typesense:masterfrom
santichausis:fix/synonym-sets-type

Conversation

@santichausis

Copy link
Copy Markdown

Summary

Closes #126

Test plan

  • mypy passes with no issues
  • ruff check passes
  • No runtime changes, type annotation only

The synonym_sets field in CollectionCreateSchema was typed as
List[List[str]], but the Typesense API expects a flat list of synonym
set names (List[str]) when linking synonym sets with collections.

See: https://typesense.org/docs/30.1/api/synonyms.html#linking-synonym-sets-with-collections

Closes typesense#126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect type annotation for synonym_sets in CollectionCreateSchema

2 participants