Repository navigation
fix: Avoid NPE on null search event or terms - #584
Open
cbartolome wants to merge 1 commit into
Open
cbartolome wants to merge 1 commit into
cbartolome wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm submitting this one in the blind, since I'm not sure how to reproduce the problem. Our metrics show
NullPointerExceptions sporadically coming from line 80 ofSearchContentController.javaand the only way those would be happening is if either the event were null or the search terms were null. We're not getting a detailed error message in our logs, so I don't know which is the case, so I fixed both possibilities.It seems that these errors may be exclusive to users using Safari.