Repository navigation
Extracted duplicated stubbings in HttpContentServiceImplTest into 2 helpers - #291
Open
mia-li-001 wants to merge 1 commit into
Open
mia-li-001 wants to merge 1 commit into
mia-li-001 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am a researcher at the university. In my analysis of the project, I observed that
In the test class
HttpContentServiceImplTest, 2 groups of stubbings are repeated across tests:testNonFormdefines the same stubbings:when(request.getParameter(HttpContentServiceImpl.IS_FORM_PARAM)).thenReturn(getParameterReturnValue)when(processor.process(any(String.class), any(PortletRequest.class))).thenReturn("http:testPostFormNoParams,testGetFormandtestGetFormNoParamsdefine the same stubbings:when(request.getParameter(HttpContentServiceImpl.IS_FORM_PARAM)).thenReturn(getParameterReturnValue)when(processor.process(any(String.class), any(PortletRequest.class))).thenReturn("http:when(request.getParameter(HttpContentServiceImpl.FORM_METHOD_PARAM)).thenReturn(getParameterReturnValue)Here
getParameterReturnValuestands for the value that differs from test to test.These duplicated stubbings repeat the setup in each test, so a change to that setup has to be made in 1 and 3 places respectively. I propose extracting them into 2 private helper methods:
setupSpringELProcessorProcessAndGetParameterStubs, which takes 1 parameter (getParameterReturnValue) and is called from 1 test and is also called bysetupSpringELProcessorProcessAndGetParameterStubs2.setupSpringELProcessorProcessAndGetParameterStubs2, which takes 1 parameter (getParameterReturnValue) and adds its own stubbings to those ofsetupSpringELProcessorProcessAndGetParameterStubsand is called from 3 tests.This refactoring also reduces the cognitive complexity of
HttpContentServiceImplTestby 24.4% (from 104.9 to 79.3, measured with Genese). Cognitive complexity, introduced by SonarSource, estimates how hard code is for a human to understand.The change only moves the existing stubbings into the helpers. The stubbed calls, arguments and returned values are the same as before, and the test results are unchanged.
I propose a solution below to remove the duplicated stubbings. Happy to modify the pull request based on your feedback.