Add REVIEW.md with automated PR review guidelines - #157
Closed
andypotanin wants to merge 2 commits into
Closed
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
Adds a root-level REVIEW.md that documents repository-specific automated PR review guidelines for the worker base image repo, focusing review attention on high-risk paths, release/versioning behavior, enforcement conventions, and secret-handling expectations.
Changes:
- Introduces
REVIEW.mdwith “critical areas” that require extra scrutiny (entrypoint, shared shell libs, Dockerfile permissions/UID, config schemas, secret resolution). - Documents the release model (GitVersion + minor release on merge to
latestwhen filtered paths change) and downstream pin/rollout implications. - Captures baseline conventions (shellcheck/hadolint/yamllint; pinned versions; canonical
make test/make build) and security expectations around cloud credentials.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
REVIEW.md:15
- This bullet attributes the "filtered path" release gating to
ci/git-version.ymland listsMakefile*, but the path filter is enforced by the GitHub Actions trigger in.github/workflows/docker-ops.yml(and it includes.dockerignore,.github/workflows/docker-ops.yml,Makefile, andMakefile.variables). Updating this section to match the actual workflow trigger will avoid misleading release guidance.
- Version comes from GitVersion (`ci/git-version.yml`): merge to `latest` cuts a Minor release automatically when a filtered path changed (`Dockerfile`, `bin/**`, `lib/**`, `src/**`, `etc/**`, `test/**`, `Makefile*`, `ci/**`). There is no changelog; the PR description is the release note - require it to state downstream impact (which child images need rebumps).
Author
|
Closing: moving this review policy into Devin's own configuration instead of repo files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a REVIEW.md instruction file that Devin Review (and other review agents) ingest automatically when analyzing PRs in this repository. It encodes repo-specific review policy: critical paths, release/versioning gates, conventions to enforce, and security expectations.
Docs-only change: no release or deploy workflow matches a root-level REVIEW.md in this repo.