You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Duplicate i18n keys in en.json5/cs.json5 break sync-i18n #192
5550 "{{message}}" → 5627 "{{fileName}} has been updated successfully"
8326 → 8490
admin.update-config.error.save.title
5552 → 5634 (same text)
8329 → 8506
admin.update-config.error.save.message
5554 "Unable to save configuration file. Please check the logs and try again." → 5635 "Could not save {{fileName}}"
8332 → 8509
admin.update-config.file-info.modified
5571 "Last Modified" → 5608 "Modified"
8366 → 8448
item.preview.dc.identifier.other
2632 → 2652 (also duplicated upstream in DSpace dspace-7_x)
3948 → 3979
In JSON5 the last definition wins, so the first entry of each pair is dead. Its text is never shown.
Why it matters
yarn run sync-i18n -t src/assets/i18n/cs.json5 -i, which the PR template asks authors to run, can't tell the two entries apart. It copies the first Czech translation onto the second (the one that takes effect) and adds a misleading TODO Source message changed. This happened in #167, where it silently changed three Czech strings. For example, error.save.message lost its {{fileName}} placeholder. The values were restored by hand there, but every future sync run will mangle them again.
Proposed fix
For each pair, remove the first (dead) entry from en.json5 and cs.json5, keeping the one that takes effect today so the UI doesn't change. Check against admin-update-config.component.ts that the kept text fits how the key is used (e.g. error.save.message is called with { fileName }).
Optionally, add a duplicate-key check to CI (or to sync-i18n) so new duplicates fail fast.
Activity
fix(i18n): remove dead duplicate entries of 6 keys (#192)
Merge pull request #197 from ufal/192-duplicate-i18n-keys-in-enjson5c…