Skip to content

Sync dataquest release lindat-2026.11.41471243025 - #199

Merged
kosarko merged 23 commits into
clarin-v7from
dataquest/conflict-resolved-dtq-dev
Nov 9, 2026
Merged

kosarko merged 23 commits into
clarin-v7from
dataquest/conflict-resolved-dtq-dev

Conversation

@kosarko

@kosarko kosarko commented Nov 9, 2026

Copy link
Copy Markdown
Member

Syncing UFAL's clarin-v7 with the dataquest-dev release lindat-2026.11.41471243025 (tagged on customer/lindat).

I merged the release tag into dataquest/conflict-resolved-dtq-dev with no conflicts, then merged origin/clarin-v7 on top and resolved the conflicts.

Conflict resolution

  • .github/workflows/build.yml: kept clarin-v7's CI choices, cypress-io/github-action@v7 (the release pins @v7.4.4) and no rerun-on-failure job (we removed it in c84a504). The release's Node [20.x, 22.x] matrix and Chrome for Testing are kept.

Every other file both sides touched merged to one side's exact content.

Notable changes from the release

  • Node 18 → 22 in Dockerfile / Dockerfile.dist; package.json / yarn.lock unchanged.
  • SSR cache key now includes protocol, Host and language cookie; static pages are fetched from ui.baseUrl, not the request Host.
  • The auth cookie gets Secure (on https only) and SameSite=Lax.
  • RefBox citation HTML is sanitised. The license-agreement page sends only the fields the license requires.
  • robots.txt disallows scoped search and facet URLs. The scoped-search rules have no /repository prefix.
  • New static pages: seven license pages, Terms of Service placeholders filled in (needs BE description.* exposure), updated Deposit page.

Verification (local)

  • yarn install --frozen-lockfile: the lockfile was unchanged.
  • yarn lint: 0 errors.
  • tsc --noEmit on tsconfig.app.json and tsconfig.spec.json: clean.
  • The specs touched by the merge, 11 files: auth, SSR cache key, html-content, license agreement, license section, download page, bitstream URL serializer, ref citation, static page, file description, response parsing. 126 of 126 pass on Node 20, ChromeHeadless.
  • Full unit and e2e suites run in CI.

Please merge with a merge commit, not a squash, so the next sync has a merge base.

Kasinhou and others added 23 commits July 30, 2026 09:41
Co-authored-by: Matus Kasak <matus.kasak@dataquest.sk>
Co-authored-by: Matus Kasak <matus.kasak@dataquest.sk>
The GitHub runner's Chrome moved from 154 to 155 on 2026-10-15 and
since then 5 to 7 random Cypress specs time out in every run. Install
Chrome for Testing with browser-actions/setup-chrome and run Cypress
with browser chrome-for-testing, as upstream dspace-angular does.
When a job fails, the backend docker compose logs are uploaded as an
artifact. Same change as on dtq-dev and dtq-dev-9-base.

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
…Space#1666)

phpmyadmin/phpmyadmin has not been pushed since 2025-10-08 (PHP 8.3.26)
and did not get the PHP security release of 2026-10-21. The Docker
Official Image "phpmyadmin" was rebuilt with PHP 8.3.36.


(cherry picked from commit c0f65ab)

Co-authored-by: Jozef Misutka <332350+vidiecan@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
)

Node 18 is end of life since April 2025 and gets no security fixes,
including CVE-2026-111497 in the Brotli decoder bundled with Node.
DSpace 7.6.7 also ships on Node 22.

CI now tests on Node 20 and 22.


(cherry picked from commit 35d18f3)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
v6 uses got@11 for its wait-on ping. On the runner's bundled Node >= 24.20
a refused connection is raised as ERR_SOCKET_CLOSED_BEFORE_CONNECTION and
aborts the e2e step instead of being retried. Fixed upstream in v7.4.4
(cypress-io/github-action#1873).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…7.4.4-lindat

CI: bump cypress-io/github-action to v7.4.4 (backport DSpace#1656)
…TML (1662) (DSpace#1677)

The citation text came from the server and was rendered with
bypassSecurityTrustHtml, so markup in item metadata could run scripts.
It now goes through Angular's sanitizer, which keeps the <i> and <a>
formatting, strips scripts and event handlers, and makes javascript:
links inert.


(cherry picked from commit a5298dd)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…wnload (DSpace#1682)

* fix(license): ensure IP address is included in anonymous user payload (ufal/dspace-angular PR 163)

* fix(license): ensure IP address is included in anonymous user payload

* test(license): add missing template dependencies to spec

(cherry picked from commit e183ad8)

* issue 162: filter clarinusermetadata/manage payload to contain only required metadata keys (ufal/dspace-angular PR 164)

* issue 162: filter clarinusermetadata/manage payload to contain only fields required by the license

* test(license): cover required-info payload filter and optional ORGANIZATION

Spec cases for ufal/dspace-angular PR 164 on top of the ufal/dspace-angular PR 163 spec setup:
- only metadata keys required by the license (plus the current IP) are sent
- an empty ORGANIZATION does not block "I agree"; an empty
  REQUIRED_ORGANIZATION still does

Both cases fail without ufal/dspace-angular PR 164's component change.

---------

Co-authored-by: Ondrej Kosarko <kosarko@ufal.mff.cuni.cz>
(cherry picked from commit a026caf)

---------

Co-authored-by: Amad Ul Hassan <hassan@ufal.mff.cuni.cz>
Co-authored-by: Milan Kuchtiak <kuchtiak@ufal.mff.cuni.cz>
Co-authored-by: Ondrej Kosarko <kosarko@ufal.mff.cuni.cz>
…e page (DSpace#1683)

* fix(static-page): interpolate  placeholders from config (ufal/dspace-angular PR 185)

Co-authored-by: Ondřej Košarko <kosarko@ufal.mff.cuni.cz>
(cherry picked from commit 45ab229)

* fix(static-page): read ${...} placeholder values from backend config (ufal/dspace-angular PR 188)

Fill the Terms of Service placeholders from /api/config/properties instead of
a new staticPage UI config section, as XMLUI did. Rename the placeholders to
the backend keys (description.*), join comma-split values with ", ", and
leave a placeholder as is when the property is missing or fails to load.
Requires ufal/clarin-dspace PR 1424.

(cherry picked from commit 550ec11)

---------

Co-authored-by: Amad Ul Hassan <hassan@ufal.mff.cuni.cz>
Co-authored-by: Ondřej Košarko <kosarko@ufal.mff.cuni.cz>
…Space#1684)

* CorefUD v1.4 License Agreement

(cherry picked from commit 4e7d72c)

* Update by MN

license hasn't been used yet

(cherry picked from commit c6b80fb)

* New licence MWE-2.0

(cherry picked from commit 146fc6d)

* Add the UMR 2.2 license

(cherry picked from commit 46a9021)

* New license licence-unisegs-1.5.html

(cherry picked from commit 1d4906f)

* Copied previous UD license.

(cherry picked from commit 8aa0ab4)

* Changes for the upcoming UD release.

(cherry picked from commit 958827e)

* add cwl 1.0 license text

(cherry picked from commit fc92e44)

* license for atrium nonpublic record

(cherry picked from commit 07d11b6)

---------

Co-authored-by: Ondrej Kosarko <kosarko@ufal.mff.cuni.cz>
Co-authored-by: Jan Štěpánek <jan.stepanek@matfyz.cz>
Co-authored-by: Dan Zeman <zeman@ufal.mff.cuni.cz>
Co-authored-by: Ondřej Košarko <ko_ok@centrum.cz>
…ed formats (DSpace#1685)

* docs(static): refresh deposit page for v7 UI (ufal/dspace-angular PR 183)

* docs(static): refresh deposit page for v7 UI

* docs(static): fix grammar and Czech icon label per review

* docs(static): cap deposit images to container width

(cherry picked from commit 60b2d5d)

* Point depositors to LINDAT format recommendations in upload step and FAQ

Add a sentence to the upload step info alert (en, cs) linking the LINDAT
centre page in the CLARIN Standards Information System, restoring the
format hint the DSpace 5 upload step had. Repoint the static FAQ
(en, cs) from the generic SIS recommended-formats list to the same
centre page.

(cherry picked from commit 29dfc5b)

---------

Co-authored-by: Amad Ul Hassan <hassan@ufal.mff.cuni.cz>
Co-authored-by: Ondrej Kosarko <kosarko@ufal.mff.cuni.cz>
…pty file description (DSpace#1686)

* fix(subject-badge): add text-wrap and text-left to prevent overflow

(cherry picked from commit 5f5b9f4)

* fix(file-description): display "N/A" when file description is empty (ufal/dspace-angular PR 167)

* fix(file-description): display "N/A" when file description is empty

* chore: apply review fixes - restore missing i18n keys and use robust test selectors

* chore(i18n): restore blank lines in cs.json5 removed by sync-i18n

Keep the key moves and new translations from the sync, but put back
the blank-line separators so the diff only shows real changes.

* chore(i18n): restore cs.json5 values mangled by sync-i18n on duplicate keys

sync-i18n mixes up keys that appear twice in en.json5/cs.json5 and put
the first Czech translation on the second (effective) entry. Restore
the clarin-v7 values for admin.update-config.file-info.modified,
admin.update-config.success.save.title and
admin.update-config.error.save.message, and drop the bogus TODOs.

---------

Co-authored-by: Ondrej Kosarko <kosarko@ufal.mff.cuni.cz>
(cherry picked from commit 3eaf3f4)

---------

Co-authored-by: amadulhaxxani <hassan@ufal.mff.cuni.cz>
Co-authored-by: Ondrej Kosarko <kosarko@ufal.mff.cuni.cz>
…yed by origin and language (DSpace#1687)

* Load SSR static content from the configured UI origin, not the Host header

During SSR, HtmlContentService built the static-file URL from the request
protocol and Host header. A request with a spoofed Host made the server fetch
/static-files/*.html from an attacker origin and render it unsanitized
(dsSafeHtml); the SSR page caches, keyed by path only, could then serve that
render to other visitors.

Use the origin of the configured ui.baseUrl (the address the Node server
listens on) instead and drop the now unused REQUEST injection.

dspace-customers issue 1083, finding R22.

* Key SSR page caches by origin and language, not only by path

getCacheKey returned req.url, but an anonymous SSR render also depends on the
request origin (protocol and Host header, e.g. citation_pdf_url via
getCurrentOrigin) and on the dsLanguage cookie. A request with a forged Host or
another language filled the bot and anonymous caches for everyone requesting
that path.

Move the key to getSsrCacheKey so it can be unit tested and include protocol,
Host and the language cookie. The /reload check now reads req.url, because the
key no longer starts with the path.

dspace-customers issue 1083, finding R22.

* Skip the SSR bot cache for authenticated requests

cacheCheck read the bot cache for any bot user agent before checking for an
authentication cookie, so an authenticated request with a bot user agent got
the anonymous cached page instead of its own render. Read either cache only
for anonymous requests; saveToCache already stores anonymous renders only.

dspace-customers issue 1083, finding R22.

* Do not load static page names that leave static-files once decoded

The static page file name comes from the URL. Express decodes the path before
serving files, so /static/..%2Findex loaded the app's own index.html into the
page. Return no content for a name that contains a path separator after
decoding (the query part is ignored), which renders the existing 404.

dspace-customers issue 1083, finding R22.

---------


(cherry picked from commit 60f6ccb)

Co-authored-by: Jozef Misutka <332350+vidiecan@users.noreply.github.com>
Co-authored-by: jm <jm@maz>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ameSite (DSpace#1688)

* Harden dsAuthInfo auth cookie with Secure and SameSite attributes

Set secure and sameSite='lax' on the auth JWT cookie written in storeToken(),
as defense-in-depth. The Secure flag is derived from the actual page protocol
(location.protocol === 'https:') so it is applied on any https page, including
behind a TLS-terminating reverse proxy, while local http dev still works.
'lax' is used rather than 'strict' so the cookie is still sent on the top-level
navigation that returns from external authentication.

* docs: shorten auth cookie security comment

---------


(cherry picked from commit 9bcd483)

Co-authored-by: Kasinhou <129340513+Kasinhou@users.noreply.github.com>
Co-authored-by: Matus Kasak <matus.kasak@dataquest.sk>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…pace#1689)

findClarinLicenseByName() pre-encoded names containing '+' (dtq-dev PR 185, added
when RequestParam did not encode). Since the 7.6.x upgrade (dtq-dev PR 941)
RequestParam encodes its value itself, so such names were sent as
%252B and the byName lookup found nothing. Drop the manual encoding.



(cherry picked from commit c3c44fc)

Co-authored-by: Jozef Misutka <332350+vidiecan@users.noreply.github.com>
Co-authored-by: jm <jm@maz>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…oo (DSpace#1690)

SSR rendered /bitstreams/<uuid>/download as 200 HTML for anonymous
requests, because window.location.replace does nothing in Node.
The anonymous branch now goes through HardRedirectService, which
answers 302 on the server and location.replace in the browser.
The logged-in branch is unchanged.


(cherry picked from commit 8430a3d)

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
DSpace#1691)

* Keep the full query string and fragment in BitstreamUrlSerializer

Split the URL at the first raw '?' or '#' instead of destructuring url.split('?'),
which dropped everything after a second raw '?' in the query and encoded a
'#fragment' into the filename.



* Assert the full path segments in the serializer tests



---------




(cherry picked from commit c3b1675)

Co-authored-by: Jozef Misutka <332350+vidiecan@users.noreply.github.com>
Co-authored-by: jm <jm@maz>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…strap null-deref on /search (DSpace#1692)

The search view-mode switch rendered <div class="btn-group" data-toggle="buttons">
with <button routerLink> children and no <input>. On window.load, the bundled
Bootstrap 4 JS runs its load.bs.button.data-api handler, which iterates
[data-toggle="buttons"] .btn and reads .checked on
querySelector('input:not([type="hidden"])'); with no input it dereferences null
and throws an uncaught pageerror ("can't access property 'checked', s is null"),
failing the Playwright consoleErrors test on /search.

The attribute is semantically wrong here (there are no toggle inputs) and inert in
stock ng-bootstrap DSpace; routerLinkActive/[class.active] already drive the active
state, so the list/grid/detail toggle is unchanged visually and functionally.

Fixes dspace-customers issue 931



(cherry picked from commit 914a688)

Co-authored-by: Kasinhou <129340513+Kasinhou@users.noreply.github.com>
Co-authored-by: Matus Kasak <matus.kasak@dataquest.sk>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
…1693)

* LINDAT/Fix the causes of the REST self link console warnings

* Only warn about REST self links the API isn't expected to change

ensureSelfLink() compares the requested url against the self link in the
response, but strips embed params from the requested url only. The REST API
echoes the request's embed params into the self link, so every request that
embeds a subresource looked broken and flooded the console:

  The response for '.../bundles/<uuid>/bitstreams?page=0&size=5' has the self
  link '.../bitstreams?page=0&embed=accessStatus&size=5'. These don't match.

The same warning also fired when the API clamped an oversized page size
(?size=9999 comes back as ?size=1000), which the REST contract mandates:
a size over the configured maximum is reset to the maximum, no error thrown.

Narrow the warning so it only fires on differences the API isn't expected to
introduce: strip embed params from both sides, and accept a page size that
shrank when the response's own page.size confirms the smaller value. A self
link that contradicts the payload it describes is still reported, as are
differing page/sort params, extra params, a size larger than requested, and a
missing self link.

The self-link normalization itself is left untouched. The response is keyed in
the object cache by that href, so which url it is normalized to stays exactly
as it was; only whether we warn changes.

Adds the first spec for this service - ensureSelfLink was untested.

Closes dspace-customers issue 862

* Don't accept an empty page as a clamped page size, and pin the rest

Mutation testing of the new spec turned up one behaviour bug and a set of
assertions that were never actually pinned down.

isReducedPageSize() accepted any smaller page size the response's page block
confirmed, including zero: asking for size=10 and getting a self link claiming
size=0 with "page": {"size": 0} was silently swallowed. A configured maximum is
never zero, so an empty page is not a clamp - require the effective size to be
greater than zero and let that case be reported again.

Also drop a redundant hasValue(payload) - the caller already guarantees it - and
note in the doc comment that running the self link through
getUrlWithoutEmbedParams() drops a fragment and a trailing slash too, so
differences limited to those stop being reported as well.

Tests added for the gaps mutation testing exposed, each verified to fail against
the corresponding mutant:
 - the page size rule tested on its own, without embed params also in play
 - the exact text of the warning, not just a substring
 - sibling _links surviving the self link being normalized
 - `size` matched as a whole param, so `pagesize` isn't mistaken for it
 - a page block confirming the size only as a string is not confirmation
 - an empty page is reported
 - a cross-origin self link is passed through untouched
 - reordered params are neither reported nor rewritten

* Cover the case where an accepted clamp hides another differing param

When isReducedPageSize() accepts a reduced page size, isUnexpectedSelfLink()
re-compares the remaining parts rather than returning early, so a legitimate
clamp can't mask a genuinely wrong page/sort. Nothing defended that: dropping
the second urlPartsDiffer() call left all 22 tests green while silently
swallowing the defect.

* Don't report a self link that only percent decoded a param value

The remaining self link warning on the home page came from the usage statistics
request: the frontend sends uri=http%3A%2F%2F... and the REST API echoes it back
decoded as uri=http://... Same value, different representation - comparing the
raw strings compares encodings, not values, which is the same kind of false
alarm as the echoed embed params.

Percent decode both sides before comparing. Decoding happens per part, after the
url was split, so a decoded & can't merge two params, and a malformed sequence
falls back to the raw part. A value that differs beyond its encoding still warns.

With this, an item page, the home page and a search page all load with zero self
link warnings against a DSpace 9.1 backend.

Also trims the doc comments on these helpers down to what isn't already obvious
from the code.

* Stop asking the REST API for pages it will never serve

Seven call sites asked for 9999 or 10000 elements to mean "give me everything".
The REST API caps a page at 1000 (Spring Data REST's spring.data.rest.max-page-size,
which DSpace leaves at its default) and silently reduces anything larger, so those
requests never returned more than 1000 anyway - they just claimed something the API
does not honour, and the difference between the requested and the effective size is
what showed up in the self link and produced the console warnings of dspace-customers issue 862:

  GET  /core/items/<uuid>/bundles?embed=primaryBitstream&size=9999
  self ...?embed=primaryBitstream&size=1000

Introduce MAX_PAGE_SIZE next to FindListOptions and use it instead. Verified against
a DSpace 9.1 backend that this returns the identical page - same totalElements, same
contents - while the self link now matches the request exactly:

  ?size=9999 -> self ?size=1000   page {size: 1000, totalElements: 1}
  ?size=1000 -> self ?size=1000   page {size: 1000, totalElements: 1}

This is upstream issue 2513, whose fix (upstream PR 3694) removed 9999 from seven components
but missed BundleDataService.findByItemAndName - still on main, dspace-9_x, dtq-dev
and dtq-dev-9-base. The three clarin-* call sites are ours.

* Stop percent-encoding the usagereports uri param

The frontend sent uri=http%3A%2F%2F... and the REST API echoed it back decoded as
uri=http://..., which made the self link differ from the requested url and produced
the self link warning on the home page.

RequestParam encodes by default; pass encodeValue=false, exactly as
AuthorizationDataService already does for its own uri param (upstream issue 3045 and PR 3046),
and carry the same TODO noting this belongs in the backend.

* Report a reduced page size again, now that nothing asks for an impossible one

Filtering the page size out of the self link comparison treated the symptom: the
frontend went on asking for 9999, the API went on reducing it to 1000, and the code
here just stopped saying so. With every call site now within MAX_PAGE_SIZE, a page
size the API reduced means a caller asked for something it was never going to get -
which is exactly what this warning exists to surface.

Drops isReducedPageSize, getPageSizes and PAGE_SIZE_PARAM, and with them the need to
pass the response payload into isUnexpectedSelfLink at all.

What stays is the part that is a genuine comparison bug rather than a filter: embed
params and percent encoding are two ways of writing the same request, so both sides
are brought to the same form before being compared. A difference in an actual value
is still reported.

Spec goes from 25 cases to 17: the nine that pinned the page size filtering are gone,
replaced by one asserting a reduced page size warns.

* Use MAX_PAGE_SIZE for the license lookups too

Three CLARIN license components already asked for exactly 1000, so they never
triggered the warning - but leaving the bare literal next to a newly introduced
MAX_PAGE_SIZE just invites the question why one place names the limit and the
other repeats it. Same value, no behaviour change; the constant now says where
the number comes from.

* Drop the uri encoding workaround instead of copying its TODO

An earlier commit here made UsageReportDataService skip encoding its uri param,
copying the workaround and the TODO that AuthorizationDataService carries:

  // TODO fix encode the uri parameter in the self link in the backend and set
  // encodeValue to true afterwards

Measured against a DSpace 9.1 backend, that TODO is based on a misreading - there
is nothing to fix in the backend. It does not decode the self link; it re-encodes
the parameter values minimally, and ':' and '/' are legal in a query component per
RFC 3986, so it has no reason to escape them:

  sent probe=a%25b -> self probe=a%25b     (not decoded)
  sent probe=a%20b -> self probe=a%20b     (not decoded)
  sent probe=a+b   -> self probe=a%20b     ('+' is a space in form encoding)
  sent uri=http%3A%2F%2Fx -> self uri=http://x

encodeURIComponent on the frontend simply encodes more than it has to. Both urls
are valid and denote the same value.

Since the comparison now decodes both sides, the encoding no longer matters, so
put the param back on the default: encoding is the safer choice for a value that
could contain '&' or '#'. Verified in a browser - the home page still logs no self
link warning with encoding restored.

The same workaround in AuthorizationDataService is left alone: it is upstream code,
it works either way, and it is out of scope here.

* Pass the already split request url into isUnexpectedSelfLink

ensureSelfLink splits the requested url into parts before the comparison, then
isUnexpectedSelfLink split the same string a second time. The branch runs on every
response whose self link differs, which after this change is every embedded list
response, so the duplicate work is not rare.

Takes the parts instead. No behaviour change.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* Merge the MAX_PAGE_SIZE import into the existing one

section-license.component.ts already imported FindListOptions from
find-list-options.model, so adding MAX_PAGE_SIZE as a second import of the same
module - under a different specifier - left the file importing one module twice.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
(cherry picked from commit d0897c2)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* LINDAT/fix(self-link): say what happened when the API reduces a page size

ensureSelfLink() logs one wording for every self link that differs from the url
it was requested with, and that wording ends with "This could mean there's an
issue with the REST endpoint". For a page size the API reduced, that points at
the wrong place: the API did exactly what its contract says, the caller asked
for a bigger page than it will ever serve. Whoever reads the console goes
looking at the backend for a frontend mistake.

Give that case its own message:

  The request for '.../bundles?size=9999' asked for a page of 9999 elements, but
  the REST API served 1000. Ask for at most MAX_PAGE_SIZE elements

It applies only when the two urls are otherwise identical, so an accepted
reduction cannot mask a wrong page or sort. Anything else keeps the generic
message, including a page that came back larger than requested.

This is the remaining half of the fix on dtq-dev. dtq-dev PR 1415 landed the rest - embed
params and percent encoding normalized on both sides, MAX_PAGE_SIZE next to
FindListOptions, and every oversized call site brought within it - so a reduced
page size now genuinely means a caller asked for something the API was never
going to serve, and the message can say so.

- src/app/core/data/dspace-rest-response-parsing.service.ts - replace
  isUnexpectedSelfLink() with selfLinkWarning(), which returns the message to
  log or undefined when there is nothing to report, and add the
  getPageSize()/withoutPageSize() helpers and the PAGE_SIZE_PARAM they match on.
  The self link is normalized either way, as before, so the url a response is
  cached under does not change - only whether and how we warn.
- src/app/core/data/dspace-rest-response-parsing.service.spec.ts - 17 cases to
  19. The reduced page size case now expects the specific wording; one new case
  pins that a reduced size is recognised alongside other params, another that a
  page differing as well falls back to the generic message.

Adapted to 7.6 from DSpace/dspace-angular PR 6083, commit 887ddec. The
9.x-only parts of that commit's file - the @dspace/* path aliases and the
inject(APP_CONFIG) refactor - are deliberately left out, which is also why the
spec keeps its plain constructor harness instead of upstream's TestBed. Same
change as FE PR 1448, which went to customer/jcu only.

Fixes dspace-customers issue 934

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
(cherry picked from commit 51796ec)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
Backport of the src/robots.txt.ejs change from mendelu 29b88bf (FE PR 1402):
block /collections/*/search, /communities/*/search and any Discovery facet
link (/*?f., /*&f.) that was saturating SSR (HTTP 504).


(cherry picked from commit ad24111)

Co-authored-by: jurinecko <juraj.roka@dataquest.sk>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
…ct-resolved-dtq-dev

# Conflicts:
#	.github/workflows/build.yml
@kosarko
kosarko merged commit a78ab80 into clarin-v7 Nov 9, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants