Repository navigation
Merge main into integrate/design-polish after to-main-5 - #690
Merged
Merged
Conversation
The to-main-5 Windows native job timed out waiting for the owned EOF: the fixture launcher's job ends its Python fake together with the launcher, so a 100 ms grace across two parallel streams can kill the fake before it logs EOF. tests/fleet.rs uses 500 ms and passes there; production keeps its 1 s default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 58020f3)
#684's longer stop grace did not fix the Windows native job: the owned EOF never arrives there at any grace. The desktop starts the accounted Fleet only on Unix (src-tauri commands.rs); Windows keeps Fleet::start, whose stream EOF tests/fleet.rs covers and which passes on Windows. Gate the file like its production caller and restore the author's 100 ms grace. The Windows accounted stop path is tracked separately. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 87efda2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main now carries the to-main-5 snapshot (#681, merged as c92110c on a green CI gate, run 41151914491). Its three commits are cherry-picks of design-polish's own #680, #684 and #688, so this merge changes no content. It only records main's history, so the next snapshot (to-main-6) starts from a common base.
🤖 Generated with Claude Code