Repository navigation
test(client): use a platform absolute source path in the setup test - #700
Merged
ufna merged 1 commit intoOct 31, 2026
Merged
Conversation
The to-main-6 Windows native job failed: "/source with spaces" is not absolute on Windows (no drive), so setup() correctly refused it. The picker supplies native paths in production; only the test needed a per-platform absolute source. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The to-main-6 run (#699, 41159207858) failed only in the Windows native job:
machine_connections::tests::confirmed_setup_uses_the_saved_revision_and_bounded_absolute_sourcepanicked with "Choose an absolute HGS source folder path."./source with spacesis not absolute on Windows, which needs a drive.setup()was right to refuse it, and in production the picker returns native paths. This makes the test useC:\source with spaceson Windows and/source with spaceselsewhere.Linux: the 6 machine_connections tests pass; Windows client/core cross-clippy passes; fmt is clean. The Windows runtime result comes from the next to-main-6 run.
🤖 Generated with Claude Code