Repository navigation
test: read the setup bundle's ./-prefixed names on Windows - #701
Merged
Merged
Conversation
#693 archives the private source snapshot with 'tar -C snapshot .', so members are './install.sh' and so on. tests/test_machines.py was updated, but the Windows-only client test still looked names up without the prefix and failed the to-main-6 Windows zip job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The to-main-6 run (#699, 41159207858) also failed in "Windows client, desktop and portable zip":
test_windows_client.test_machine_resolution_is_bounded_and_setup_uploads_a_posix_bundleexpected bundle members without a prefix. #693 archives the private source snapshot astar -C snapshot ., so names are./install.shand so on. Remote extraction handles that, andtests/test_machines.pywas already updated. This normalises the names and readsinstall.shthrough its member. The CRLF refusal later in the test runs before the snapshot (src/machines.rs:426), so it's unaffected.This test runs only on Windows. I checked the lookup locally against a synthetic
./-prefixed archive; the Windows result comes from the next to-main-6 run.🤖 Generated with Claude Code