Repository navigation
Upgrade Go to 1.26 to fix govulncheck - #24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the Security workflow pass again. The govulncheck job fails on
mainbecause Go 1.25 has known vulnerabilities in the standard library, and the fixes are only in Go 1.26.9 and later.Before and after
Before: CI uses Go 1.25 (go1.25.14). govulncheck finds 9 standard library vulnerabilities and the job fails with exit code 3.
After: CI, the Security workflow, and the Docker image use Go 1.26 (go1.26.10 today). govulncheck exits with code 0.
Risk
CI and the Docker image now build with Go 1.26. The minimum Go version in
go.moddoes not change. Reverting this PR fully undoes it.Evidence
govulncheck@v1.7.0 ./...on go1.26.10, the same command that CI runs:I did not run the test suite locally. The CI checks on this PR will show it.
What changed
Bug fixes:
Checklist