Add sol upstream power - #4504
Merged
Merged
Conversation
… SOL parallel area
…pstream SOL parallel power flux
…ux in ScrapeOffLayer
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4504 +/- ##
==========================================
- Coverage 49.14% 49.14% -0.01%
==========================================
Files 152 152
Lines 29777 29803 +26
==========================================
+ Hits 14635 14647 +12
- Misses 15142 15156 +14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kj5248
requested changes
Aug 6, 2026
kj5248
left a comment
Collaborator
There was a problem hiding this comment.
Think you made a slight mistake for the equation for parallel area
…responding test value
clmould
requested changes
Aug 7, 2026
clmould
left a comment
Collaborator
There was a problem hiding this comment.
Some v minor changes but otherwise all good !
Co-authored-by: clmould <86794332+clmould@users.noreply.github.com>
clmould
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces new calculations and documentation for the scrape-off layer (SOL) parallel energy flux and area, and integrates them into the codebase and output. It also adds new physics variables for total magnetic fields at the inboard and outboard midplane, updates plotting and output routines to include these, and improves the documentation with references and formulas.
Scrape-off layer parallel flux and area calculations:
a_plasma_outboard_sol_eich13_parallel) and parallel power flux (pflux_plasma_outboard_sol_eich13_parallel_mw) toScrapeOffLayer, including a new methodcalculate_upstream_sol_outboard_parallel_areaand corresponding unit test.ScrapeOffLayerto display the new SOL parallel area and flux values.Magnetic field calculations and variables:
b_plasma_inboard_total,b_plasma_outboard_total) and their calculation in the main physics model.Documentation updates:
These changes improve the physical fidelity of the SOL model, enhance the clarity and completeness of outputs, and provide better documentation for users and developers.## Description
Checklist
I confirm that I have completed the following checks: