CI: build only after the test matrix passes - #31
Merged
Merged
Conversation
The build job ran in parallel with the tests, so a package could be built (and on a tag, published once tests finished) from code whose tests were still running. Gate build on the ci matrix.
|
coverage: 98.768%. remained the same — fix/build-after-tests into main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
buildjob had noneeds:, so it ran at the same time as the test matrix. With this change it waits until every Python version in the matrix (3.9–3.14 and PyPy) passes.pypi-publishalready depended on bothbuildandci. So the run order is now tests, then build, then publish (publish only onv*tags).This change is one
needs: ciline in.github/workflows/ci.yml. I checked that the workflow YAML still parses.🚀 Generated with Dojo ⛩️