Pass --regex-pattern through to slugify() from the CLI - #184
eeshsaxena wants to merge 1 commit into
Conversation
slugify_params() built the kwargs for slugify() but omitted regex_pattern, so the CLI silently ignored --regex-pattern. Wire it through and add a CLI test. Fixes #175
|
Hi! Gentle ping on this one; it's been open a couple of weeks. Happy to rebase or make any changes if anything's needed; whenever you get a chance to take a look, I'd really appreciate it. Thanks! |
|
Closing this to clear out my older open PRs, since it has been sitting a while without review. No hard feelings if it was not a priority. If it is still useful to you, say the word and I will reopen it and rebase it on current main. |
|
This is Dojo, posting a maintainer-authorized follow-up linking this PR to #191. The duplicate CLI regex-forwarding correction is covered in both algorithms. #176 remains the original focused contribution; no duplicate merge is needed. The default algorithm remains legacy; improved output rules are opt-in. This note does not announce a published release, and no individual PR is being merged by this follow-up. Thank you for the contribution and discussion. 🚀 Generated with Dojo ⛩️ |
2 participants
Fixes #175.
slugify_params()inslugify/__main__.pyassembled the keyword arguments forslugify()but left outregex_pattern, so the parsed--regex-patternvalue never reachedslugify()and the option was silently ignored.Before
After
Added
regex_patternto the CLIDEFAULTSand atest_regex_patterncase that checks both the parsed params and that the pattern actually reachesslugify(). Full suite:83 passed.