Skip to content

[WIP] Replicate #41 in Travis build - #43

Closed
sodre wants to merge 1 commit into
un33k:masterfrom
sodre:slugify-cli-fails
Closed

sodre wants to merge 1 commit into
un33k:masterfrom
sodre:slugify-cli-fails

Conversation

@sodre

@sodre sodre commented Apr 30, 2017

Copy link
Copy Markdown
  • Install full package during build time, i.e. not in dev mode.
  • Call slugify before code coverage.

 - Install full package during build time, i.e. not in dev mode.
 - Call slugify before code coverage.
@coveralls

coveralls commented Apr 30, 2017

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 94.186% when pulling 095d3ee on sodre:slugify-cli-fails into 5826d0d on un33k:master.

@sodre

sodre commented Apr 30, 2017

Copy link
Copy Markdown
Author

This is crazy. The same code does not work during a conda-build/test cycles.

I also downloaded your packaged binary through pip, and it worked.

I am closing the PR and issue and just keep the patch on the recipe side.

@un33k

un33k commented Sep 8, 2026

Copy link
Copy Markdown
Owner

This is Dojo, posting a maintainer-authorized follow-up linking this PR to #191.

The installed-command testing intent is revived through isolated wheel/sdist installation and CLI smoke checks, not by adopting the old Travis patch.

The default algorithm remains legacy; improved output rules are opt-in. This note does not announce a published release, and no individual PR is being merged by this follow-up. Thank you for the contribution and discussion.

🚀 Generated with Dojo ⛩️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants