Skip to content

Create command line tool that can set all parameters - #92

Merged
un33k merged 4 commits into
un33k:masterfrom
jdevera:full_cli
Apr 9, 2020
Merged

un33k merged 4 commits into
un33k:masterfrom
jdevera:full_cli

Conversation

@jdevera

@jdevera jdevera commented Mar 14, 2020

Copy link
Copy Markdown
Collaborator

I was in need of a CLI tool that did what the original entrypoint did but with some specific parameters different from defaults. So I decided to make it available for anybody and contribute it back.

This PR adds a slugify command that can take as arguments any of the parameters of the function with the same name.

I've added tests that verify that different combinations of command-line arguments result in the expected parameters passed to the function. They do not re-test the functionality.

@coveralls

coveralls commented Mar 14, 2020

Copy link
Copy Markdown

Coverage Status

Coverage increased (+2.3%) to 94.839% when pulling abfd30e on jdevera:full_cli into e785874 on un33k:master.

@un33k

un33k commented Mar 14, 2020

Copy link
Copy Markdown
Owner

This is create, could you add one section to the readme.md before Running the tests, call it Command Line Options. Thank you for your great contribution.

@jdevera

jdevera commented Mar 15, 2020

Copy link
Copy Markdown
Collaborator Author

Thanks for the feedback. I added the suggested section to the README and, in the process, I found I had left one change uncommitted 🤦‍♂ so I pushed that too. Plus one more test :)

@jdevera

jdevera commented Apr 7, 2020

Copy link
Copy Markdown
Collaborator Author

For almost a month I did not realise that I had not pushed the change I said to have done. Now the PR should have the additions you asked for.

@un33k

un33k commented Apr 9, 2020

Copy link
Copy Markdown
Owner

Yeah, I knew the situation was not good in Spain, and I was hoping that you were doing OK, and would find time to make the change. I am glad you are fine and healthy and thank you for your contribution. I will push it up on the next revision change.

@un33k

un33k commented Sep 8, 2026

Copy link
Copy Markdown
Owner

This is Dojo, posting a maintainer-authorized follow-up linking this PR to #191.

CLI parameter parity is extended with regex forwarding and explicit algorithm/backend/replacement-stage controls.

The default algorithm remains legacy; improved output rules are opt-in. This note does not announce a published release, and no individual PR is being merged by this follow-up. Thank you for the contribution and discussion.

🚀 Generated with Dojo ⛩️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants