Skip to content

fix(player): HEVC with in-band-only parameter sets plays in Tier B again - #13

Merged
uplg merged 1 commit into
mainfrom
fix/hevc-bare-hvcc
Nov 3, 2026
Merged

uplg merged 1 commit into
mainfrom
fix/hevc-bare-hvcc

Conversation

@uplg

@uplg uplg commented Nov 3, 2026

Copy link
Copy Markdown
Owner

The real cause of the iPad « Buffering » (#11 blamed the audio, wrongly).

The Price of Confession (TFA) ships a bare 23-byte hvcC (extradata_size=23): no VPS/SPS/PPS arrays, the parameter sets only travel in the stream.

  • Safari: Tier B writes an hvc1 sample entry with no parameter sets, VideoToolbox can't start → black « Buffering », no error, no demotion.
  • Zen (Gecko macOS): the CRA splicer refused the record (hvcC carries no SPS/PPS) → Tier E (WASM transcode), too slow for 10-bit 1080p → buffering loop.

completeHvcc() rebuilds the record from the keyframe the run starts on, for the muxer and the splicer alike.

Tests:

  • The 10-bit E-AC-3 bench clip now has the same bare hvcC (fixtures/bare-hvcc.py). Without the fix it is stuck at 0 s on WebKit iPad and refused by the splice on Firefox; with it, 1x on both.
  • Full bench (chrome, firefox, webkit, ipad, phone): 79 passed, 0 failed, 17 skipped.
  • Unit tests for completeHvcc; bun run check clean, bun run test 595 green.

…ier B again

The Price of Confession (TFA) ships a bare 23-byte hvcC: no VPS/SPS/PPS
arrays, the parameter sets repeat in the stream. Tier B writes an hvc1
sample entry, which carries them out-of-band: Safari's VideoToolbox could
not start (black « Buffering », no error, no demotion), and the Gecko-mac
CRA splicer refused the record and fell to the WASM transcode (Zen
buffering in a loop). completeHvcc() fills the record from the keyframe
the run starts on, for the muxer and the splicer alike.

Bench: the 10-bit E-AC-3 clip now has the same bare hvcC
(repeat-headers + fixtures/bare-hvcc.py, which empties the CodecPrivate
in place behind an EBML Void). It stalls at 0 s on the iPad and is
refused by the splice on Firefox without the fix, and plays with it.
CHANGELOG and the msePlaysAudio comment corrected: the first fix blamed
the audio.
@uplg
uplg merged commit 059f4d7 into main Nov 3, 2026
@uplg
uplg deleted the fix/hevc-bare-hvcc branch November 3, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant