Repository navigation
fix(player): HEVC with in-band-only parameter sets plays in Tier B again - #13
Merged
Merged
Conversation
…ier B again The Price of Confession (TFA) ships a bare 23-byte hvcC: no VPS/SPS/PPS arrays, the parameter sets repeat in the stream. Tier B writes an hvc1 sample entry, which carries them out-of-band: Safari's VideoToolbox could not start (black « Buffering », no error, no demotion), and the Gecko-mac CRA splicer refused the record and fell to the WASM transcode (Zen buffering in a loop). completeHvcc() fills the record from the keyframe the run starts on, for the muxer and the splicer alike. Bench: the 10-bit E-AC-3 clip now has the same bare hvcC (repeat-headers + fixtures/bare-hvcc.py, which empties the CodecPrivate in place behind an EBML Void). It stalls at 0 s on the iPad and is refused by the splice on Firefox without the fix, and plays with it. CHANGELOG and the msePlaysAudio comment corrected: the first fix blamed the audio.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The real cause of the iPad « Buffering » (#11 blamed the audio, wrongly).
The Price of Confession (TFA) ships a bare 23-byte hvcC (
extradata_size=23): no VPS/SPS/PPS arrays, the parameter sets only travel in the stream.hvc1sample entry with no parameter sets, VideoToolbox can't start → black « Buffering », no error, no demotion.hvcC carries no SPS/PPS) → Tier E (WASM transcode), too slow for 10-bit 1080p → buffering loop.completeHvcc()rebuilds the record from the keyframe the run starts on, for the muxer and the splicer alike.Tests:
fixtures/bare-hvcc.py). Without the fix it is stuck at 0 s on WebKit iPad and refused by the splice on Firefox; with it, 1x on both.completeHvcc;bun run checkclean,bun run test595 green.