Repository navigation
Align the landing page with other pages' sidebar gap - #909
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
|
Docs7 for upstash.com
Commit |
ramazanoacar
left a comment
ramazanoacar
left a comment
There was a problem hiding this comment.
LGTM once docs7#506 is deployed. I checked the numbers against the renderer: 24/36/44 px match PAGE_GUTTER (px-6 sm:px-9 md:px-11), the lg/xl steps match columnPad (lg:px-(--docs-column-gap), xl:pl-[calc(var(--docs-column-gap)+var(--docs-panel-inset))]), the variables are defined on :root[data-docs-theme="mint"] so .u-wrap can read them, and 63.75rem content-box plus the 24 px inset reproduces the old 1068 px. The comment pointing at page-gutter.ts is the right breadcrumb for the coupling.
The link-rot failure is not this PR: the last three merged PRs report the same 52 broken links.
One caveat: this encodes #506's fixed-inset rule. If the review there lands on Mintlify-style centering instead, this CSS needs to follow, so hold the merge until that is settled.
There was a problem hiding this comment.
🟢 Approval recommended
The focused CSS change consistently implements the documented responsive spacing behavior.
0 open findings
What changed in this PR
Aligns the framed landing page’s content inset and maximum width with standard documentation pages.
Changes:
- Adds responsive page gutters below
lg. - Uses docs7 column and panel spacing variables at larger widths.
- Preserves the existing 1020px content maximum.
| File | Description |
|---|---|
style.css |
Updates responsive landing-page width and inset rules. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The landing page (
introduction.mdx,mode: frame) sat a different distance from the sidebar than other pages, and the difference changed with the window width.Why:
mode: framegives the page the whole content area with no inset..u-wrapcentered itself in that area, so the gap was(area − 1068px) / 2 + 24px. Other pages start the article at docs7's column inset.Fix:
.u-wrapstarts at the same inset as the article on other pages. Below lg, the inset is the page gutter (24/36/44px). From lg up, it is docs7's--docs-column-gap(+--docs-panel-insetfrom xl). The content width keeps the old 1020px maximum.Deploy order: merge after upstash/docs7#506. That PR stops docs7 from centering articles that have no ToC. Before #506, normal pages add a centering offset, and the landing does not match them.
Gap from the sidebar to the h1 (from the window edge below 1024px), measured on a local docs7 renderer with #506. Columns: landing,
/qstash/sdks/ts/overview(no ToC),/redis/overall/getstarted: