Repository navigation
test(delete-previous-head-image): delete a real previous head image - #75
Closed
vcauesantos wants to merge 4 commits into
Closed
vcauesantos wants to merge 4 commits into
vcauesantos wants to merge 4 commits into
Conversation
…ared with a release
Contributor
Author
|
Throwaway test for loft-sh/github-actions#347. Runs 41729014649, 42079889490 and 42082465256 proved the action against real GHCR images; not merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happened
loft-sh/github-actions#347 adds the
delete-previous-head-imageaction. It deletes the head image a new push replaces in GHCR. We needed proof that it deletes a real signed image and keeps everything else, before candy uses it.What this PR changes
A caller workflow that runs the action against real GHCR images. It pushes two signed test heads with different content and a signed release, then runs the action in record and delete mode. The check script confirms the old head's versions are gone. It also confirms
headand the release still pull on both architectures and passcosign verify. A second delete with the same digest must change nothing.A second job covers a platform shared with a release. The release signs its amd64 manifest on its own, and the old head reuses that manifest. After the delete, the old head and its signature must be gone. The shared manifest, its
sha256-<digest>signature tag andcosign verifyon it must still work. This is the case from the #347 review.It pins the released
delete-previous-head-image/v1tag. The earlier runs used the PR branch commit. This run checks the tag callers will use, including the review fixes.How it was tested
headandv0.0.1pull and verify, the repeat delete was a no-op.v1tag): the same checks passed.v1tag, both jobs): passed. The shared-platform job deleted the old head index and its signature (3 versions) and kept the shared amd64 manifest, its signature index and signature (3 versions, "also part of tag v0.0.2").cosign verifypassed on the shared manifest and on the release.Related to DEVOPS-1807