Repository navigation
Make jobs drain-cancelable - #27
Merged
OAharoni-RedHat merged 1 commit intoNov 16, 2026
Merged
Conversation
The external-secrets validation job is a poll loop and the config jobs run long ansible playbooks, so a node drain evicting one of these pods could burn backoffLimit retries or leave the work half-done. - Validation job: SIGTERM trap exits 143 so a cancelled run is never marked successful - All three Jobs (validation, bootstrap, config cronjob): podFailurePolicy ignores DisruptionTarget drain evictions and exit code 143, so evictions do not burn backoffLimit and a replacement pod resumes the work. The config jobs omit containerName since both the agof-init (bash) and agof-config (timeout-wrapped make) containers exit 143 on SIGTERM. - terminationGracePeriodSeconds: 60 on all job pods so a drain is never blocked waiting for a pod Note: the exit-code rule requires operator: In, and the drain-eviction rule must use onPodConditions with type DisruptionTarget (there is no onDisruptionConditions field). Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The external-secrets validation job is a poll loop and the config jobs
run long ansible playbooks, so a node drain evicting one of these pods
could burn backoffLimit retries or leave the work half-done.
marked successful
ignores DisruptionTarget drain evictions and exit code 143, so
evictions do not burn backoffLimit and a replacement pod resumes the
work. The config jobs omit containerName since both the agof-init
(bash) and agof-config (timeout-wrapped make) containers exit 143 on
SIGTERM.
blocked waiting for a pod
Note: the exit-code rule requires operator: In, and the drain-eviction
rule must use onPodConditions with type DisruptionTarget (there is no
onDisruptionConditions field).
Co-Authored-By: Claude Code noreply@anthropic.com