Skip to content

Add AAP Starter Kit - #744

Merged
laubai merged 6 commits into
validatedpatterns:mainfrom
mhjacks:add_aap_sk
Nov 2, 2026
Merged

laubai merged 6 commits into
validatedpatterns:mainfrom
mhjacks:add_aap_sk

Conversation

@mhjacks

@mhjacks mhjacks commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@openshift-ci

openshift-ci Bot commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@mhjacks

mhjacks commented Oct 16, 2026

Copy link
Copy Markdown
Contributor Author

/test all

@ocpdocs-previewbot

ocpdocs-previewbot commented Oct 16, 2026 •

Copy link
Copy Markdown

🤖 Thu Oct 22 18:36:58 - The preview is ready at:
https://744--patternsdocs-pr.netlify.app

@mhjacks

mhjacks commented Oct 16, 2026

Copy link
Copy Markdown
Contributor Author

/test all

@mhjacks

mhjacks commented Oct 16, 2026

Copy link
Copy Markdown
Contributor Author

/test all

@mhjacks
mhjacks marked this pull request as ready for review October 16, 2026 16:55
@openshift-ci
openshift-ci Bot requested review from kquinn1204 and laubai October 16, 2026 16:55
@mhjacks
mhjacks requested review from day0hero and removed request for kquinn1204 October 16, 2026 16:55
@mhjacks

mhjacks commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author

/test all

@laubai laubai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General recommendations in addition to the specific comments throughout:

  • Bullets with orphan paragraphs in a number of places, e.g. under “Pattern scripts” in “Installation details”
  • Confirm Ansible version to link out to - current links are for 2.4, but “Keep the AAP release field aligned with the operator channel (stable-2.7).” - possibly because changed link structure as of version 2.6 made it hard to find the new docs location?
  • Some indication of time required to deploy pattern would be useful, e.g. when can the user start to expect to begin verifying that pods and namespaces are available.

@mhjacks
mhjacks requested a review from laubai October 23, 2026 15:16

@laubai laubai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge, will make minor consistency tweaks as a separate PR.

@openshift-ci openshift-ci Bot added the lgtm label Nov 2, 2026
@laubai
laubai merged commit d32ab9f into validatedpatterns:main Nov 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants