Repository navigation
Allow setting storageclass on external data volumes - #25
Merged
OAharoni-RedHat merged 3 commits intoNov 16, 2026
Merged
Conversation
mhjacks
marked this pull request as draft
November 12, 2026 19:10
The set-default-virt-storageclass and wait-for-metal-node jobs are poll loops that can run for a long time (e.g. waiting for ODF), and jobTerminationGracePeriod was 3600, so a node drain evicting one of these pods blocked the MCO drain for up to an hour. - SIGTERM trap exits 143 so a cancelled run is never marked successful - podFailurePolicy ignores DisruptionTarget drain evictions and exit code 143, so evictions do not burn backoffLimit and a replacement pod resumes the wait - Reduce jobTerminationGracePeriod 3600 -> 60 Regenerate README.md via make helm-docs. Co-Authored-By: Claude Code <noreply@anthropic.com>
The podFailurePolicy added in 159ea0d was rejected by the API server: - onExitCodes requires an operator field (In/NotIn); add operator: In - onDisruptionConditions is not a valid field; the API server saw rule[1] as having no matcher at all. Replace it with onPodConditions matching the DisruptionTarget condition, which is the documented way to ignore drain evictions. Fix both job templates (set-default-virt-storageclass, wait-for-metal-node) and update the unit test assertions to match. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.