Skip to content

Allow setting storageclass on external data volumes - #25

Merged
OAharoni-RedHat merged 3 commits into
validatedpatterns:mainfrom
mhjacks:enhance_ds_check
Nov 16, 2026
Merged

OAharoni-RedHat merged 3 commits into
validatedpatterns:mainfrom
mhjacks:enhance_ds_check

Conversation

@mhjacks

@mhjacks mhjacks commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@mhjacks
mhjacks marked this pull request as draft November 12, 2026 19:10
Martin Jackson and others added 2 commits November 12, 2026 17:33
The set-default-virt-storageclass and wait-for-metal-node jobs are
poll loops that can run for a long time (e.g. waiting for ODF), and
jobTerminationGracePeriod was 3600, so a node drain evicting one of
these pods blocked the MCO drain for up to an hour.

- SIGTERM trap exits 143 so a cancelled run is never marked
  successful
- podFailurePolicy ignores DisruptionTarget drain evictions and
  exit code 143, so evictions do not burn backoffLimit and a
  replacement pod resumes the wait
- Reduce jobTerminationGracePeriod 3600 -> 60

Regenerate README.md via make helm-docs.

Co-Authored-By: Claude Code <noreply@anthropic.com>
The podFailurePolicy added in 159ea0d was rejected by the API server:
- onExitCodes requires an operator field (In/NotIn); add operator: In
- onDisruptionConditions is not a valid field; the API server saw rule[1]
  as having no matcher at all. Replace it with onPodConditions matching
  the DisruptionTarget condition, which is the documented way to ignore
  drain evictions.

Fix both job templates (set-default-virt-storageclass, wait-for-metal-node)
and update the unit test assertions to match.

Co-Authored-By: Claude Code <noreply@anthropic.com>
@mhjacks
mhjacks marked this pull request as ready for review November 13, 2026 18:13
@OAharoni-RedHat
OAharoni-RedHat merged commit 67eab30 into validatedpatterns:main Nov 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants