Repository navigation
Update make install and fix verify_image() - #189
Merged
Merged
Conversation
OAharoni-RedHat
force-pushed
the
squash
branch
from
November 2, 2026 15:08
a1fe9ad to
4c49993
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR covers 2 separate issues:
2. In a recent update for RHTAS 1.4.4, changes were made to EC which causedverify_image()to no longer succeed on the first run of the qtodo supply chain pipeline. In this commit we update to using cosign rather than EC which will still verify the image without requiring the SLSA attestation (which is only created after the pipeline completes the first time). This change was written using Claude as I am not an SME in this area. I'll gladly change how this is done or leave it to you folks to fix if you'd prefer! I can say I've tested this successfully and the code as it stands does work.^ The following seems to have been fixed upstream and was removed from this PR. It now only refers to fixing up make install and a small error introduced in pattern.sh in a previous PR.