Skip to content

Update make install and fix verify_image() - #189

Merged
mlorenzofr merged 1 commit into
validatedpatterns:mainfrom
OAharoni-RedHat:squash
Nov 2, 2026
Merged

mlorenzofr merged 1 commit into
validatedpatterns:mainfrom
OAharoni-RedHat:squash

Conversation

@OAharoni-RedHat

@OAharoni-RedHat OAharoni-RedHat commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

This PR covers 2 separate issues:

  1. Make install was customized in this pattern (within makefile-common) which would cause issues if patternizer were ever to be used to update other commands. We've updated the command to allow for skipping the argo healthchecks more natively without causing issues in the CI which does require the running of argo healthchecks to properly work. There should be no changes to your workflow from this.

2. In a recent update for RHTAS 1.4.4, changes were made to EC which caused verify_image() to no longer succeed on the first run of the qtodo supply chain pipeline. In this commit we update to using cosign rather than EC which will still verify the image without requiring the SLSA attestation (which is only created after the pipeline completes the first time). This change was written using Claude as I am not an SME in this area. I'll gladly change how this is done or leave it to you folks to fix if you'd prefer! I can say I've tested this successfully and the code as it stands does work.

^ The following seems to have been fixed upstream and was removed from this PR. It now only refers to fixing up make install and a small error introduced in pattern.sh in a previous PR.

@mlorenzofr mlorenzofr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlorenzofr
mlorenzofr merged commit 10e37e5 into validatedpatterns:main Nov 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants