Repository navigation
chore(deps): update dependency shell-quote to v1.11.0 [security] - #896
openshift-merge-bot[bot] merged 1 commit into
Conversation
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
|
Hi @red-hat-konflux[bot]. Thanks for your PR. I'm waiting for a validatedpatterns member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
/ok-to-test |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbaldessari, red-hat-konflux[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR contains the following updates:
1.10.0→1.11.0Warning
Some dependencies could not be looked up. Check the warning logs for more information.
shell-quote:
quote()command injection via a line terminator in a token after a{ comment }tokenCVE-2026-102422 / GHSA-pqg4-j6r4-53mv
More information
Details
Impact
quote()emits a{ comment }token as#followed by its text, which comments out the rest of the shell line, including the opening quote of any later string token. A line terminator in that later string ends the comment, and the rest of the string is parsed as shell input:Passed to
sh,bash,dash,ksh, orzsh, this runsid.parse()emits a comment token for a#in the middle of a word (for examplehttp://example.com/#frag), so callers that combineparse()output with another untrusted string, such asquote(parse(untrustedCommand).concat(untrustedArg)), are affected. The fix for CVE-2026-9277 rejected line terminators in the comment's own text, but not in the tokens after it.Exploitation requires an attacker-controlled string containing a line terminator that follows a
{ comment }token in the samequote()call.Patches
Fixed in v1.11.0:
quote()throws aTypeErrorwhen a string after a{ comment }token contains a line terminator (\n,\r, U+2028, or U+2029).Workarounds
Drop every token after a
{ comment }token before callingquote(), or reject line terminators in untrusted strings. Separately, do not append other shell text afterquote()output that contains a comment, since the comment swallows it.Severity
CVSS:4.0/AV:N/AC:L/AT:P/PR:N/UI:N/VC:H/VI:H/VA:H/SC:N/SI:N/SA:NReferences
This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).
Release Notes
ljharb/shell-quote (shell-quote)
v1.11.0Compare Source
Fixed
quote: drop a replace that can never match in the single-quote branch#15parse: support bash ANSI-C quoting ($'...')#32Commits
quote: reject line terminators in tokens after acomment6002b2eparse: preserve text after special shell parameters81b08a5parse: an escaped backslash does not escape the character after itd708019quote: preserve!in arguments that also contain'ad39927parse: treat$_nameas a variable name, not$_followed by text28f88cdquote: preserve empty glob patterns35c9b97quote: escape~in glob patterns to prevent shell tilde-expansion239d49c@ljharb/eslint-config,auto-changelog,eslint,evalmdb1e406eebfc3083429b0dcache-mode36f2394eslint6de9a41Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.