Repository navigation
Conversation
# Details - Related to #1895 - Remove `ms_use_builtin_bwe` Meson option and every `MS_USE_BUILTIN_BWE` usage in the C++. - `WebRtcTransportOptions` and `PlainTransportOptions`: Add `enableBwe`, `initialAvailableOutgoingBitrate`, `minOutgoingBitrate`, `maxOutgoingBitrate` and `maxIncomingBitrate`. - **Breaking change:** `WorkerSettings` no longer takes `libwebrtcFieldTrials`. - **Breaking change:** The transport "bwe" trace event now reports `desiredBitrate`, `minBitrate`, `maxBitrate` and `availableBitrate`. - Remove all old BWE related classes. - Remove `worker/deps/libwebrtc`. - Remove `abseil-cpp` Meson subproject (it was only needed by the old `libwebrtc` dependency).
46 of 56 tasks
Member
Author
|
NOTE: clang-tidy workflow fails due to so many files in the git diff (because |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
ms_use_builtin_bweMeson option and everyMS_USE_BUILTIN_BWEusage in the C++.WebRtcTransportOptionsandPlainTransportOptions: AddenableBwe,initialAvailableOutgoingBitrate,minOutgoingBitrate,maxOutgoingBitrateandmaxIncomingBitrate.WorkerSettingsno longer takeslibwebrtcFieldTrials.desiredBitrate,minBitrate,maxBitrateandavailableBitrate.worker/deps/libwebrtc.abseil-cppMeson subproject (it was only needed by the oldlibwebrtcdependency).