Skip to content

Fix multinode-HA guide test failure on TLS package deploy - #2003

Open
sarzhann with Copilot wants to merge 1 commit into
masterfrom
copilot/fix-github-actions-job-main-test
Open

sarzhann with Copilot wants to merge 1 commit into
masterfrom
copilot/fix-github-actions-job-main-test

Conversation

Copilot AI commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

The main / test GitHub Actions job was failing in the examples/operations/multinode-HA guide during the TLS-secured application deploy step. The HTTPS config server upload path was using a streamed zip payload that failed before activation completed.

  • Root cause

    • The guide deployed the application package with a streamed archive:
      zip -r - ... | curl --data-binary @- https://localhost:19071/application/v2/tenant/default/prepareandactivate
    • In CI, that TLS upload path failed during the curl request, so the guide test never observed prepared and activated.
  • Change

    • Update the TLS deploy example in examples/operations/multinode-HA/README.md to create the application package as a real zip file under /tmp and upload that file directly.
    • This keeps the guide flow unchanged while avoiding the failing streamed upload path.
  • Guide update

    zip -r /tmp/multinode-ha-app.zip . -x "tls/*" "pki/*" "scripts/*" "gke/*" "img/*" README.md .gitignore services.xml.open "*.yaml"
    curl \
      --key pki/vespa/host.key --cert pki/vespa/host.pem --cacert pki/vespa/ca-vespa.pem \
      --header Content-Type:application/zip --data-binary @/tmp/multinode-ha-app.zip \
      https://localhost:19071/application/v2/tenant/default/prepareandactivate

Copilot AI changed the title [WIP] Fix failing GitHub Actions job 'main / test' Fix multinode-HA guide test failure on TLS package deploy Sep 25, 2026
Copilot AI requested a review from sarzhann September 25, 2026 07:26
@sarzhann
sarzhann marked this pull request as ready for review September 25, 2026 14:06
@sarzhann
sarzhann requested a balanced review from Copilot September 28, 2026 07:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused documentation change directly addresses the reported CI failure without altering the deployment flow.

Review effort: Balanced
Findings: None

What changed in this PR

Updates the multinode HA guide’s TLS deployment flow to avoid unreliable streamed uploads.

Changes:

  • Creates the application package as a temporary ZIP file.
  • Uploads the ZIP directly with curl.
File Description
examples/​operations/​multinode-HA/​README.md Revises the TLS deployment commands to use a file-backed ZIP upload.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@sarzhann
sarzhann enabled auto-merge September 28, 2026 13:20
@sarzhann
sarzhann requested a review from kkraune September 28, 2026 13:20
Co-authored-by: sarzhann <32760183+sarzhann@users.noreply.github.com>

This branch was successfully deployed

1 active deployment
Vespa Cloud CD — afaa4b35 Deployed Sep 29, 2026 by sarzhann via Push to Vespa Cloud #1380
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants