Repository navigation
Separate verify failure templates for static and suggested - #100
Merged
Merged
Conversation
Split verify failure handling into dedicated paths with separate templates for each. Render templated feedback for spec context while appending full command output to logs for debugging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors verify failure feedback to use dedicated templates for static and suggested checks. Rather than wrapping failure output in a shared template, each failure type now renders its own self-contained section with a heading, intro sentence, and bulleted list of failing commands—without command output included in the prompt context.
Full command output is preserved in per-step log files and additionally appended to
implement-spec.logfor the failed attempt, allowing investigators to trace what triggered each retry without bloating the implementation agent's prompt.Changes include:
static_verify_errors.mdandsuggested_verify_errors.mdreplacingverify_errors.md_format_commands_bullets(),_render_static_verify_failures(),_render_suggested_verify_failures(),_format_static_verify_failures(),_append_failure_block()_render_prompt()to insertverify_errorsverbatim instead of wrapping with templateTest plan
_format_commands_bullets()verify single and multiple command formatting_render_static_verify_failures()and_render_suggested_verify_failures()verify heading, intro, bullets appear and output does notimplement-spec.logafter failures- cmd) instead of full output inverify_errorstest_format_suggested_failures_structure()still passes against output-included function_render_prompt()inserts error sections verbatim without adding wrapper heading