ngrep: update to 1.49.0, adopt#61336
Conversation
|
I noticed that there is already an existing PR for this but it's been idle for 3 weeks and was flagged as AI, so I'm submitting a proper one. While that PR does switch to PCRE2 it only adds cross-compilation flags for libpcap and completely forgot pcre2. This version adds proper cross-compilation for both, includes --disable-pcap-restart to prevent rnutime crashes on newer libpcap (used by Arch, Alpine etc. This PR also updates the 'update' file to the new distfile pattern. |
| site="https://github.com/jpr5/ngrep/releases" | ||
| pattern="V\K[\d\_]*(?=\.tar\.gz)" | ||
| site="https://api.github.com/repos/jpr5/ngrep/releases/latest" | ||
| pattern="tag_name.*v\K[\d\.]+" |
There was a problem hiding this comment.
Can you check whether that update file is even required?
There was a problem hiding this comment.
Not necessarily but it was already there so I updated it alongside the template. Its not a must-have but its nice to have.
There was a problem hiding this comment.
Why is nice to have if the default just works?
There was a problem hiding this comment.
I looked at the GitHub releases again. The default update check should handles this fine since it's a straightforward GitHub release with a clean version tag, so the watch file is redundant. I'll remove it tomorrow when I'm home
2 participants
Testing the changes
Local build testing