You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(sdk): use std's no-op waker in the sharing policy test helper - #124
Rust 1.98.1 (brought in by the upstream sync, #122) flags our hand-written no-op Wake impl in crates/buzz-sdk/src/sharing/policy/tests.rs with clippy::manual_noop_waker, which fails Rust / Rust Lint on main. This switches to Waker::noop(). Test-only; cargo clippy --workspace --all-targets -- -D warnings passes locally on 1.98.1.
Rust 1.98.1, which the upstream sync brought in, flags the hand-written
no-op `Wake` impl (clippy::manual_noop_waker), failing `just clippy` on
main. Use `Waker::noop()` instead.
Signed-off-by: Tee8z <tee8z@protonmail.com>
No actionable comments were generated in the recent review.
Walkthrough
The policy test module removes its custom no-op Wake implementation and uses Waker::noop() in the immediate-future polling helper. The imports no longer include Arc or Wake.
Changes: Policy test waker
Layer / File(s)
Summary
Update the polling helper crates/buzz-sdk/src/sharing/policy/tests.rs
The complete helper polls with Waker::noop(). The test imports remove Arc and Wake.
This test-helper cleanup is ready to merge with no identified production impact.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the main change: replacing the manual no-op waker with the standard library's Waker::noop() in the sharing policy test helper.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Reviewing files that changed from the base of the PR and between 5364323 and 765b954.
Files selected for processing: 1
crates/buzz-sdk/src/sharing/policy/tests.rs
Included review availability: This review used your included allowance. 1 included review remains after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust 1.98.1 (brought in by the upstream sync, #122) flags our hand-written no-op
Wakeimpl incrates/buzz-sdk/src/sharing/policy/tests.rswithclippy::manual_noop_waker, which fails Rust / Rust Lint onmain. This switches toWaker::noop(). Test-only;cargo clippy --workspace --all-targets -- -D warningspasses locally on 1.98.1.🤖 Generated with Claude Code
Summary by CodeRabbit