Repository navigation
Conversation
The macOS x86_64 package took about 61 minutes on macos-15-intel, 51 of them compiling, against 17 for the same build on macos-14. Build it on macos-14 with --target x86_64-apple-darwin instead. package-macos.sh takes BUZZ_GPUI_MACOS_ARCH. When it differs from the machine, it sets CARGO_BUILD_TARGET and PKG_CONFIG_ALLOW_CROSS (the universal GStreamer framework carries x86_64), and reads the binaries from target/<triple>/release. build-package.sh stages the relay provider in that same directory. Native builds are unchanged. The x86_64 job installs Rosetta, which its checks need to run the bundled x86_64 Node and provider, and the two architectures get separate Rust caches now that they share a runner image. Signed-off-by: Tee8z <tee8z@protonmail.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The macOS x86_64 package is the long pole of every GPUI release: about 61 minutes on
macos-15-intel, 51 of them in the compile step. The identical build takes 17 minutes onmacos-14(Apple Silicon). Timings are from release run 41893713064,v0.2.0+voltage.1.What
Build the x86_64
.dmgonmacos-14with--target x86_64-apple-darwin:package-macos.shtakesBUZZ_GPUI_MACOS_ARCH. When it differs from the machine's arch, the script:CARGO_BUILD_TARGETandPKG_CONFIG_ALLOW_CROSStarget/<triple>/releaseThe GStreamer framework the job installs is the universal
.pkg, so it carries x86_64, andbundle-macos-gstreamer.pyalready thins to the requested arch. Node is already chosen per arch. Native builds are unchanged.build-package.shstages the relay provider in the sametarget/<triple>/release.Workflow, for the x86_64 job:
macos-14with thex86_64-apple-darwintargetcheck-macos-dmg.shruns the bundled x86_64 Node and providerValidation
scripts/test-package-build.py: new case for a cross build staging the provider beside the cross-built app. It fails against the oldbuild-package.sh; all 4 cases pass with the change.actionlintis clean;bash -npasses on both scripts.check-macos-dmg.shresult show whether the cross build is correct. Expect the x86_64 job near the arm64 one's ~20 minutes. The first run of each cache key starts cold.Not yet verified: the x86_64
.dmglaunching on a real Intel Mac. That needs a human with one before this leaves draft.package-macos.shandbuild-package.shalso exist in benthecarman/buzz-gpui. The change is generic, so it can be offered upstream withscripts/upstream-buzz-gpui.sh.🤖 Generated with Claude Code