You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(gpui): make the Nix release package evaluate - #127
error: The "src" package has been renamed to "simple-revision-control".
nix/appimage.nix declared src ? fetchurl { inherit url hash; } as an argument. callPackage fills any argument whose name nixpkgs defines, and nixpkgs defines src as a throwing alias. So the AppImage source was replaced by that alias, which failed when the wrapper evaluated it. #126's release pin is correct, but nothing could build from it.
This computes src in a let binding instead, a one-line change.
Verified
nix build path:apps/buzz-gpui#buzz-gpui-voltage-bin builds buzz-gpui-0.2.0+voltage.2 from the v0.2.0+voltage.2 AppImage. The pinned hash matches the release asset.
buzz-gpui --gst-check from the built package passes (encodes and plays an MP4 inside the appimageTools environment), and the .desktop entry is installed.
Before the fix, the same build fails with the error above.
Unblocks NixOS hosts that install buzz-gpui-voltage-bin, as described in voltage/remote-agents.md.
AppImage builds now retrieve their source using the configured download location and integrity check, improving consistency in how the application package is assembled. No changes to the app’s features or behavior are included.
nix/appimage.nix took `src ? fetchurl { ... }` as an argument. callPackage
fills any argument whose name nixpkgs defines, and nixpkgs defines `src` as
an alias that throws ("renamed to simple-revision-control"), so
buzz-gpui-voltage-bin never evaluated, from the release pin in #126 on.
Compute src in a let binding instead. The package now builds from
v0.2.0+voltage.2, and its --gst-check passes.
Signed-off-by: Tee8z <tee8z@protonmail.com>
voltagecloud/buzz#87: The issue requests a Linux AppImage or similar package. This change updates the Nix AppImage derivation, but does not implement the full installer or release workflow.
Possibly related PRs
voltagecloud/buzz#121: This PR introduced the AppImage derivation that this change updates.
Suggested labels:human review wanted
Suggested reviewers:thebrandonlucas
Merge Risk: Minimal · up to f1589
The change addresses the AppImage source-fetching evaluation issue without an identified remaining merge blocker.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title names the fix and its scope: the Nix release package (gpui) now evaluates. The raw summary shows the change in apps/buzz-gpui/nix/appimage.nix removes the optional src argument and fetches t…
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the fix and its scope: the Nix release package (gpui) now evaluates. The raw summary shows the change in apps/buzz-gpui/nix/appimage.nix removes the optional src argument and fetches the source from url and hash, which matches the title. The objectives describe the same cause, where callPackage supplied nixpkgs' throwing src alias and broke evaluation of buzz-gpui-voltage-bin. The title is concise and specific enough for a teammate scanning history to find the primary change.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Reviewing files that changed from the base of the PR and between 8d7dee4 and f1589e5.
Files selected for processing: 1
apps/buzz-gpui/nix/appimage.nix
Included review availability: This review used your included allowance. 1 included review remains after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buzz-gpui-voltage-bin(#121) has never evaluated:nix/appimage.nixdeclaredsrc ? fetchurl { inherit url hash; }as an argument.callPackagefills any argument whose name nixpkgs defines, and nixpkgs definessrcas a throwing alias. So the AppImage source was replaced by that alias, which failed when the wrapper evaluated it. #126's release pin is correct, but nothing could build from it.This computes
srcin aletbinding instead, a one-line change.Verified
nix build path:apps/buzz-gpui#buzz-gpui-voltage-binbuildsbuzz-gpui-0.2.0+voltage.2from the v0.2.0+voltage.2 AppImage. The pinned hash matches the release asset.buzz-gpui --gst-checkfrom the built package passes (encodes and plays an MP4 inside the appimageTools environment), and the.desktopentry is installed.Unblocks NixOS hosts that install
buzz-gpui-voltage-bin, as described involtage/remote-agents.md.🤖 Generated with Claude Code
Summary by CodeRabbit