You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat(mobile): add an independent Voltage Commons distribution - #97
Independent iPhone builds currently inherit Buzz’s name, bee artwork, and Block signing defaults. This adds an opt-in Voltage Commons distribution with its own icon, splash screen, welcome identity, permission copy, and About credits. Ordinary builds retain the upstream branding.
The proposed permanent bundle ID is cloud.voltage.workspace. The display name remains a working name. The iOS variant registers voltage-workspace://, while pasted/scanned Buzz links and canonical shared message links remain supported. A native build gate binds Flutter branding to the native identity and rejects mismatches. Commons configuration leaves the signing team unset until Voltage supplies its own team.
The About entry credits Block and links to upstream and fork sources; the license viewer includes the complete upstream Apache license. The mobile guide records signing prerequisites and contains an unsent courtesy note for upstream maintainers.
Validation:
Flutter formatting and analysis pass.
Nineteen Commons branding/settings tests and three unconfigured-push tests pass.
A fresh Linux-target Flutter asset bundle omitted the Commons SVG before the manifest fix and includes the exact SVG afterward. This verifies Flutter asset packaging, not an iOS device build.
The full default mobile suite completed with 3,255 passes, four skips, and one existing video-controller timing failure. That unchanged video case passes on an isolated rerun.
Production build-gate/preparation checks, asset/XML checks, workflow lint, and the differential file-size gate were validated for the unchanged native setup earlier in this PR.
Draft: no Apple device build or TestFlight upload has been performed. A new macOS CI job builds the complete unsigned Commons app. Signed distribution still requires Voltage’s Apple account, app/extension/group registrations, capabilities, provisioning, and distribution credentials. Human acceptance should check launch, onboarding, Settings → About → licenses, permission prompts, and side-by-side links on an iPhone. Human acceptance remains pending.
Summary by CodeRabbit
New Features
Added a Voltage Commons iPhone app experience with its own name, icon, launch screen, and onboarding branding.
Added an About screen with app attribution and license information.
Added support for Voltage Commons links and handoffs while retaining existing Buzz link compatibility.
Updated permission prompts and in-app messages to reflect the selected app name.
Documentation
Added guidance for preparing and building the Voltage Commons iPhone app.
Limit details: You’ve used all 3 included reviews currently available. Your 45 included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour.
This change adds an independently branded Voltage Commons iOS build path. It configures native and Flutter branding, updates app surfaces and deep-link handling, packages the Buzz license, and adds build preparation, validation, tests, workflow automation, and documentation.
iOS settings select the Commons bundle identity, icon, launch screen, and URL scheme. Preparation and build scripts validate the configuration. The workflow builds an unsigned iOS app and runs the branding test.
Shared branding and license registration mobile/lib/shared/branding/*, mobile/lib/main.dart, mobile/assets/licenses/buzz-LICENSE.txt, mobile/pubspec.yaml, mobile/test/shared/branding/app_brand_test.dart
Flutter defines the distribution name and attribution, registers the packaged Buzz license for Commons builds, and provides the Commons mark widget. Tests check the bundled license.
App titles, prompts, onboarding, settings, and bee widgets use distribution-specific names or Commons artwork. Tests cover the Commons presentation and About entry.
Distribution-specific deep links mobile/lib/shared/deeplink/deep_link.dart, mobile/test/shared/branding/app_brand_test.dart
Deep-link parsers accept voltage-workspace only in Commons builds and continue to accept buzz. Tests check these conditions.
sequenceDiagram
participant Workflow as Voltage Commons mobile workflow
participant Prepare as prepare-commons-ios.sh
participant Xcode as Xcode build phase
participant Gate as require-app-brand.sh
participant Flutter as Flutter build
Workflow->>Prepare: Create AppOverrides.xcconfig
Workflow->>Xcode: Start the iOS release build
Xcode->>Gate: Validate native branding and DART_DEFINES
Gate-->>Xcode: Return validation result
Xcode->>Flutter: Run build after the branding gate
Loading
Suggested reviewers:thebrandonlucas
Merge Risk: Moderate · previous review b1f0d
In the Voltage Commons build, the Commons mark would fail to load on onboarding and the bee surfaces because its SVG is not declared as a Flutter asset. Default Buzz builds are unaffected. Add the asset to pubspec.yaml before merging.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "feat(mobile): add an independent Voltage Commons distribution" matches the main change in the changeset. The raw summary shows an opt-in iOS distribution with separate branding (icon, launc…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "feat(mobile): add an independent Voltage Commons distribution" matches the main change in the changeset. The raw summary shows an opt-in iOS distribution with separate branding (icon, launch screen, app display name, bundle settings, URL scheme), a build gate, a preparation script, and a Commons xcconfig. The title is specific and concise and follows a conventional commit style.
Full details: Docstring Coverage
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 3 functions across 3 files. (34 skipped: 34 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
CI triage: Clients / Mobile exceeded the job's 30-minute limit. GitHub's annotation explicitly reports that timeout. The cold Flutter SDK setup consumed 13 minutes 30 seconds; formatting, analysis, the full Flutter test suite, unconfigured-push tests, and recipe checks then passed. The job was cancelled during Android APK assembly, with no test assertion failure.
I have restarted that job using the SDK cache saved by the first attempt. This is a setup/build timeout, not a flaky test to waive. Android build coverage is pending the rerun. The iOS Swift/build lane passed; the PR remains draft for the signed-device and human acceptance work described above.
Closing at the author’s request: we are keeping the existing iPhone app unchanged and are not pursuing an independent Voltage Commons distribution. The server-side launch work in #108 is the intended path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Independent iPhone builds currently inherit Buzz’s name, bee artwork, and Block signing defaults. This adds an opt-in Voltage Commons distribution with its own icon, splash screen, welcome identity, permission copy, and About credits. Ordinary builds retain the upstream branding.
The proposed permanent bundle ID is
cloud.voltage.workspace. The display name remains a working name. The iOS variant registersvoltage-workspace://, while pasted/scanned Buzz links and canonical shared message links remain supported. A native build gate binds Flutter branding to the native identity and rejects mismatches. Commons configuration leaves the signing team unset until Voltage supplies its own team.The About entry credits Block and links to upstream and fork sources; the license viewer includes the complete upstream Apache license. The mobile guide records signing prerequisites and contains an unsent courtesy note for upstream maintainers.
Validation:
Draft: no Apple device build or TestFlight upload has been performed. A new macOS CI job builds the complete unsigned Commons app. Signed distribution still requires Voltage’s Apple account, app/extension/group registrations, capabilities, provisioning, and distribution credentials. Human acceptance should check launch, onboarding, Settings → About → licenses, permission prompts, and side-by-side links on an iPhone. Human acceptance remains pending.
Summary by CodeRabbit