Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an Errors section to the output reference. It gives:
error.detail.http_statusanderror.detail.data.error.typeor.code. The API sends these and the CLI keeps them unchanged. The CLI only replaces secret values with[REDACTED].exit_codeis the CLI's failure class (3 for 401 and 403, 1 for other API errors), not the HTTP status.messageandhintare written for people, so scripts must not match on them.message. A request that gets no response has nohttp_status.Each claim matches
src/api.rs(ErrorDetail::Httpbuilt from the response body) andsrc/output.rs(report_error). Integration tests assert it:report["error"]["detail"]["data"] == rejection,report["error"]["detail"]["http_status"], andHTTP 403: non-JSON response omitted.Checks
master. It changes docs only (16 insertions, 1 deletion indocs/reference/output.md).src/ortests/changed and no test readsoutput.md.CHANGELOG.mdline: the CLI's behavior does not change.