feat(geo): add native LineString, MultiPoint, MultiLineString types#8679
Open
HarukiMoriarty wants to merge 1 commit into
Open
feat(geo): add native LineString, MultiPoint, MultiLineString types#8679HarukiMoriarty wants to merge 1 commit into
LineString, MultiPoint, MultiLineString types#8679HarukiMoriarty wants to merge 1 commit into
Conversation
Complete the set of OGC simple-feature geometries alongside the existing Point/Polygon/MultiPolygon: - vortex.geo.linestring - List<Struct<x, y[, z][, m]>> - vortex.geo.multipoint - List<Struct<x, y[, z][, m]>> - vortex.geo.multilinestring - List<List<Struct<x, y[, z][, m]>>> Each mirrors the existing Polygon/MultiPolygon extension types: GeoArrow import/export with separated (struct) coordinates, WKB literal decoding, geo_types conversion for the geo scalar functions, and registration in initialize(). LineString/MultiPoint share a storage shape (as do MultiLineString/Polygon); they are disambiguated by their GeoArrow extension name and Vortex extension id, not by shape. Wire them through the DuckDB integration so they surface as GEOMETRY like the existing native types: the dtype -> GEOMETRY mapping, per-type WKB exporters, and native-geometry-column recognition for predicate pushdown. Tests cover dtype validation across all four dimensions, Arrow field import/export (including that the shape-identical types resolve by name), and WKB-literal decode round-trips. Signed-off-by: Nemo Yu <zyu379@wisc.edu>
Merging this PR will not alter performance
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing 
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete the set of OGC simple-feature geometries alongside the existing Point/Polygon/MultiPolygon:
Each mirrors the existing Polygon/MultiPolygon extension types.
Wire them through the DuckDB integration so they surface as GEOMETRY like the existing native types: the dtype -> GEOMETRY mapping, per-type WKB exporters, and native-geometry-column recognition for predicate pushdown.
Tests cover dtype validation across all four dimensions, Arrow field import/export (including that the shape-identical types resolve by name), and WKB-literal decode round-trips.