Ci/modernise actions - #55
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR modernizes the repository’s CI setup by updating GitHub Action versions, restructuring workflows (including a new consolidated CI workflow), and introducing explicit OpenAPI generator CLI versioning configuration.
Changes:
- Added
openapitools.jsonto pin the OpenAPI Generator CLI version. - Updated multiple workflows to newer action versions and broadened push branch triggers.
- Replaced the standalone
panaworkflow with a new multi-job.github/workflows/ci.yaml(generate → analyze/pana).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| openapitools.json | Pins OpenAPI Generator CLI version for reproducible generation. |
| generate.sh | Removes Homebrew install step for the generator and relies on generator availability. |
| .github/workflows/test.yml | Updates action versions and adjusts push branch trigger pattern. |
| .github/workflows/pana.yml | Removes the old package analysis workflow (replaced by CI workflow). |
| .github/workflows/major-dependency-upgrades.yaml | Updates action versions for dependency upgrade automation. |
| .github/workflows/generate.yml | Updates action versions and pins Homebrew setup action by SHA. |
| .github/workflows/ci.yaml | Introduces a consolidated CI workflow with generation + analysis + pana. |
Suppressed comments (1)
.github/workflows/ci.yaml:43
- Uploading the entire workspace (
path: .) withinclude-hidden-files: truewill likely include.gitand other unnecessary files, inflating artifact size and slowing down CI. The downstream jobs only need the Dart packages, so restrict the artifact contents to those directories.
- uses: actions/upload-artifact@v7
with:
name: dart-generated
path: .
include-hidden-files: true
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| # Ensure openapi-generator is installed and up to date | ||
| brew install openapi-generator | ||
| openapi-generator generate -g dart-dio -c generator-config.yaml |
Comment on lines
39
to
43
| - name: Set up Homebrew | ||
| uses: Homebrew/actions/setup-homebrew@master | ||
| uses: Homebrew/actions/setup-homebrew@fd832223f9f99ebf0244dd20658680e5d4aca049 | ||
|
|
||
| - name: Generate | ||
| run: ./generate.sh |
Comment on lines
39
to
+41
| - name: Create Pull Request | ||
| if: steps.pubspec_check.outputs.changed | ||
| uses: peter-evans/create-pull-request@v6 | ||
| uses: peter-evans/create-pull-request@v8 |
Comment on lines
+27
to
+30
| - uses: vrchatapi/specification/.github/actions/setup-generator@main | ||
|
|
||
| - uses: vrchatapi/specification/.github/actions/download@main | ||
| with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.