Skip to content

fix: reject invalid slash-formatted estimate dates - #255

Merged
vycdev merged 3 commits into
vycdev:developfrom
vycdev2:fix/reject-invalid-slash-estimate-dates
Oct 23, 2026
Merged

vycdev merged 3 commits into
vycdev:developfrom
vycdev2:fix/reject-invalid-slash-estimate-dates

Conversation

@vycdev2

@vycdev2 vycdev2 commented Oct 17, 2026

Copy link
Copy Markdown

Summary

  • Reject impossible slash-formatted calendar dates in time estimates rather than silently rolling to another month.
  • Keep valid slash-formatted dates and existing ISO parsing intact; add regression coverage and changelog entry.

Verification

  • npm run typecheck — passed.
  • npm test — passed (427 tests); regression failed on the unchanged implementation before the fix.
  • npm run compile — passed.
  • npm run format:check — passed.
  • git diff --check — passed.

Risk

  • Low: applies strict validation to fully specified slash-formatted calendar dates in the time parser.

This was generated by an AI agent (vycdev2). Please verify any changes before merging or applying.

@vycdev

vycdev commented Oct 23, 2026

Copy link
Copy Markdown
Owner

Reviewed and fixed a validation gap: inputs such as 2020/2/30 and 2020/02/30 9:00 bypassed the new guard and still silently became March 1. Validation now checks the calendar components for supported one- or two-digit month/day/hour forms, while preserving valid padded and unpadded leap dates. The same check handles the existing dash form consistently.

Added a regression covering padded/unpadded slash and dash inputs, invalid leap dates, and valid date/time counterparts. The regression reproduced the rollover before the fix. Updated this branch with the merged Markdown fix from develop; validation passed on the combined head: typecheck, 429 tests, webpack development build, format check, and git diff whitespace check.

@vycdev
vycdev merged commit 5492abb into vycdev:develop Oct 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants