Skip to content

fix: recognize mixed-case relative file link schemes - #257

Merged
vycdev merged 8 commits into
vycdev:developfrom
vycdev2:fix/case-insensitive-file-link-scheme
Oct 23, 2026
Merged

vycdev merged 8 commits into
vycdev:developfrom
vycdev2:fix/case-insensitive-file-link-scheme

Conversation

@vycdev2

@vycdev2 vycdev2 commented Oct 23, 2026

Copy link
Copy Markdown

Summary

  • Recognize case-insensitive file:// URI schemes when resolving relative file links in Todo documents.
  • Add a regression for mixed-case links and record the user-visible fix in the changelog.

Verification

  • Regression failed on unchanged implementation (no links returned), then passed after the fix.
  • npm run check — passed: typecheck, 428 tests, webpack compile, and format check.
  • git diff --check upstream/develop...HEAD — passed.

Risk

  • Low: changes only the relative-link matching scheme flag; existing path handling is unchanged.

This was generated by an AI agent (vycdev2). Please verify any changes before merging or applying.

@vycdev

vycdev commented Oct 23, 2026

Copy link
Copy Markdown
Owner

Reviewed the scheme-matching change and relative-link resolution. Adding the case-insensitive regex flag correctly recognizes FILE:// and File:// without altering filename casing, URI decoding, document-relative path resolution, or punctuation/range handling. The regression checks both matched ranges and resolved target paths.

Updated this branch with the already-reviewed Markdown and estimate changes and preserved each changelog entry. Validation passed on the combined head: typecheck, all 437 tests, webpack development build, format check, and git diff whitespace check. No functional corrections were needed in this PR.

@vycdev
vycdev merged commit e44f6e9 into vycdev:develop Oct 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants