Skip to content

fix: refresh date-based time estimates on recalculation - #258

Merged
vycdev merged 4 commits into
vycdev:developfrom
vycdev2:fix/refresh-date-estimates
Oct 23, 2026
Merged

vycdev merged 4 commits into
vycdev:developfrom
vycdev2:fix/refresh-date-estimates

Conversation

@vycdev2

@vycdev2 vycdev2 commented Oct 23, 2026

Copy link
Copy Markdown

Summary

  • Recalculate calendar and natural-language @est values on refresh instead of reusing a stale cached duration.
  • Keep caching explicit, reference-independent durations.
  • Add regression tests for advancing reference times.

Verification

  • npm run typecheck passed.
  • npm run compile passed.
  • npm test passed (430 tests).
  • npm run format:check passed.
  • git diff --cached --check passed.

Risk

  • Low: affects estimate caching only; dynamic expressions may cost more to parse on refresh.

This was generated by an AI agent (vycdev2). Please verify any changes before merging or applying.

@vycdev

vycdev commented Oct 23, 2026

Copy link
Copy Markdown
Owner

Reviewed and fixed a timer integration regression introduced by uncaching calendar estimates. For a task started at noon with an estimate of 14:00, the timer correctly showed 1:30:00 at 12:30, but editing the task recalculated its estimate from the current time and subtracted the elapsed 30 minutes again, changing the countdown to 1:00:00.

The timer now resolves its estimate from the task's preserved start time and timestamp offset; statistics still refresh date-dependent estimates from the current reference time. Added integration regressions using the real time, statistics, and timekeeping implementations for task edits, fixed-duration estimates, delayed opening, and sub-minute precision. The affected calendar tests failed before the correction and pass afterward.

Integrated current develop and retained all changelog entries. Validation passed on this head: typecheck, 436 tests, webpack development build, format check, and git diff whitespace check.

@vycdev
vycdev merged commit 4132221 into vycdev:develop Oct 23, 2026
4 checks passed
@est

est commented Oct 23, 2026

Copy link
Copy Markdown

hello?

@vycdev

vycdev commented Oct 23, 2026

Copy link
Copy Markdown
Owner

hello?

Sorry didn't mean to mention your username.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants