Repository navigation
fix: exclude bundled dependencies from the packaged extension - #261
Merged
Merged
Conversation
Webpack already bundles every runtime dependency into out/extension.js, so the packaged node_modules folder (2,519 files) was unused. The .vsix shrinks from 5.06 MB to 2.71 MB. Verified the packaged bundle loads without node_modules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Webpack bundles every runtime dependency into
out/extension.js, so thenode_modulesfolder vsce was packaging (2,519 files, 5.85 MB unpacked) is never loaded. The onlynode_modulespaths in the bundle point at VS Code's own built-in ripgrep.node_modules/**to.vscodeignore.Verification
vsce package(3.9.2): 37 files, 2.71 MB, down from 2,556 files and 5.06 MB..vsixand loadedout/extension.jsin plain Node with a stubvscodemodule and nonode_modules: it loads and exportsactivate.