fix(hooks): quote plugin paths with spaces - #5
Open
AndrewDongminYoo wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Codex provides the plugin location through
PLUGIN_ROOT.The current manifest commands expand that value without quoting the executable path.
A plugin root that contains spaces is split into multiple shell words, so every matching hook exits with code 127.
This change keeps the existing
PLUGIN_ROOTcontract and quotes only the executable path.It is narrower than the approach in #4, which replaced the root variable.
Validation
jq empty plugins/warp/hooks/hooks.json plugins/orchestration/hooks/hooks.jsonbash -n tests/test-hooks.shbash tests/test-hooks.sh(63 passed, 0 failed)git diff --check