[QUALITY-2068] Fix macOS computer-use recording output frame rate - #15920
Merged
Conversation
Co-Authored-By: Warp <agent@warp.dev>
vkodithala
marked this pull request as ready for review
September 10, 2026 18:05
Contributor
|
I ran into an unexpected error while working on this. Powered by Oz |
vkodithala
changed the title
vkodithala
commented
Sep 10, 2026
vkodithala
left a comment
vkodithala
left a comment
Contributor
Author
There was a problem hiding this comment.
Small nit, LG!
Comment on lines
+224
to
+227
| // AVFoundation timestamps frames with a microsecond timebase. Without | ||
| // an explicit output rate, ffmpeg treats that as an extremely high | ||
| // constant frame rate and duplicates frames until the file duration | ||
| // collapses toward zero. |
Contributor
Author
There was a problem hiding this comment.
nit: We probably shouldn't include context around the regression this fixed here!
Co-Authored-By: Warp <agent@warp.dev>
danielpeng2
approved these changes
Sep 10, 2026
Co-Authored-By: Warp <agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
macOS computer-use recordings can render an initial frame but report a duration near 0 seconds and contain excessive duplicated frames. This adds an explicit FFmpeg output frame rate to the macOS
avfoundationcapture command, matching the configured capture rate.The AVFoundation demuxer exposes frames with a microsecond timebase. Without an output
-r, FFmpeg interprets that as an extremely high constant frame rate (observed as 1,000,000 fps), duplicates frames to satisfy it, and produces a near-zero-duration MP4. The Linux recorder already constrains its output rate; this change brings the macOS path in line.Linked Issue
Linked Linear issue here: https://linear.app/warpdotdev/issue/QUALITY-2068/macos-runner-computer-use-videos-are-0-seconds-and-unedited-vs-linux.
Testing
cargo fmt --all -- --check— passed.cargo nextest run -p computer_use -E 'test(sets_output_frame_rate_to_capture_rate)'— passed.cargo nextest run -p computer_use— 81 passed, 2 skipped../script/presubmit— formatting passed, but the full build could not complete because the machine ran out of disk space while writing Rust metadata (No space left on device). The full build should be rerun in an environment with sufficient space.No full GUI integration test was added because the regression is directly covered at the deterministic FFmpeg command-builder seam and the end-to-end capture requires a display-dependent macOS environment.
I have manually tested my changes locally with
./script/runScreenshots / Videos
Not applicable: this is a native FFmpeg command-line fix; end-to-end playback validation requires a macOS display environment.
Agent Mode
CHANGELOG-BUG-FIX: Fixed macOS computer-use recordings reporting near-zero duration.
Co-Authored-By: Warp agent@warp.dev