Fix broken mock closure arity blocking CI on master - #15923
Closed
joeywangzr wants to merge 1 commit into
Closed
Conversation
`AIClient::list_ambient_agent_tasks` gained a third parameter (`request_team_scope: Option<RequestTeamScope>`) in #15811, but one mock closure in `repeated_viewer_registration_starts_one_ancestor_seed_fetch` was not updated to match, breaking the build: error[E0593]: closure is expected to take 3 arguments, but it takes 2 arguments This is a hard compile error in the `warp` crate's test target, so it currently fails Formatting + Clippy and Run tests CI jobs on every platform for any PR based on current master. Co-Authored-By: Warp <agent@warp.dev>
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![warp-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR updates the MockAIClient::expect_list_ambient_agent_tasks closure in orchestration_event_streamer_tests.rs to match the current three-argument AIClient::list_ambient_agent_tasks signature.
Concerns
- No blocking concerns found. The diff changes only test mock arity, adds no comments, does not introduce new test-coverage issues, has no approved spec commitments to compare against, and does not affect security-sensitive behavior.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
masterfails to compile its test target:AIClient::list_ambient_agent_tasksgained a third parameter in #15811, but one mock closure inorchestration_event_streamer_tests.rswas never updated to match:This blocks Formatting + Clippy and Run tests CI (all platforms) for every PR based on current
master. Confirmed by building a cleanmastercheckout in isolation, no other changes applied.Fix:
|_, _|→|_, _, _|on the closure, which returns a canned error regardless of input.Linked Issue
No linked GitHub issue; urgent trunk-CI fix.
Testing
cargo check -p warp --tests --libpassescargo nextest run -p warp repeated_viewer_registration_starts_one_ancestor_seed_fetchpassescargo fmt --checkandcargo clippy --all-targets -- -D warningspass./script/runnot applicable — one-line test-only fixAgent Mode
CHANGELOG-NONE
Co-Authored-By: Warp agent@warp.dev