Skip to content

Add feature for animation event animation accessors - #4444

Merged
ddbeck merged 3 commits into
web-platform-dx:mainfrom
ddbeck:add-feature-for-animation-event-animation-access/qktqyqtszouu
Oct 5, 2026
Merged

ddbeck merged 3 commits into
web-platform-dx:mainfrom
ddbeck:add-feature-for-animation-event-animation-access/qktqyqtszouu

Conversation

@ddbeck

@ddbeck ddbeck commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator

Fixes #4107

@Elchi3 Elchi3 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really sure if these two add-ons are a feature on its own. If they are, I think we should try harder to mention what they offer.

@@ -0,0 +1,9 @@
name: Animation accessors
description: The `animation` property of an `AnimationEvent` or `TransitionEvent` object is the `Animation` object that triggered the event.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: The `animation` property of an `AnimationEvent` or `TransitionEvent` object is the `Animation` object that triggered the event.
description: The `animation` property of an `AnimationEvent` or `TransitionEvent` object represents which Animation (and thus which element) fired a certain animation event.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your approach and adapted it into c4deaf6.

Co-authored-by: Florian Scholz <349114+elchi3@users.noreply.github.com>
@ddbeck

ddbeck commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator Author

Not really sure if these two add-ons are a feature on its own. If they are, I think we should try harder to mention what they offer.

So I found myself with three plausible paths here:

  1. No feature. Add the keys to animation-css and pretend this PR (and the inciting issue) never happened.
  2. Mint the feature now, as I've done. Then merge it into animation-css at some point in the future, when have the machinery and this feature passes whatever qualifications we ultimately set for feature merging.
  3. Defer this decision entirely. Wait until we get feature merging, then reconsider what to do with these keys then.

I initially wanted to lump it into animation-css. The trouble is that almost everything there is substantially older (e.g., Baseline ~2020 or earlier). I figured that, if we had created this feature in June when it was requested, there would have been no way of knowing that it would be Baseline today and it would have been a more straightforward candidate for a standalone feature (i.e., it would have been more difficult to make the case that we should not mint the feature at all).

If we had a feature merging apparatus already in place, I'd advocate for a fast merge, where a minor extension to an existing feature hits Baseline high means we immediately fold it into its antecedent feature. We could still do that, once we get feature merging in.

Or we could say, yes, it would have been the correct thing to do three months ago, but since we didn't do the correct thing now, we should pretend it never happened in the first place and silently fold it in. That feels a little bit bad.

@ddbeck
ddbeck requested a review from Elchi3 October 5, 2026 13:51

@Elchi3 Elchi3 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for elaborating! I think I now agree that mining a feature is the better path forward. Should we leave a comment in the yml that says "Merge into animation-css when this feature becomes baseline high" ?

@ddbeck
ddbeck merged commit f258815 into web-platform-dx:main Oct 5, 2026
3 checks passed
@ddbeck
ddbeck deleted the add-feature-for-animation-event-animation-access/qktqyqtszouu branch October 5, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature definition Creating or defining new features or groups of features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Animation accessor on AnimationEvent and TransitionEvent

2 participants