Conversation
wpt-pr-bot
requested review from
annevk,
foolip,
jdm,
jgraham and
mkruisselbrink
October 1, 2026 15:39
nicolo-ribaudo
force-pushed
the
remove-messageport-close-event
branch
from
October 1, 2026 22:00
229405e to
a91f536
Compare
6 tasks done
annevk
approved these changes
Oct 2, 2026
annevk
pushed a commit
to whatwg/html
that referenced
this pull request
Oct 2, 2026
This is a revert of cc2634f (it's not a "clean" revert because of some other changes that happened in the meantime). This means that this patch also restores the older GC semantics: a port is not easily GC-able, it is not explicitly disentangled when the other half's owner document is destroyed, and relies on polling to see if the other half is still alive. I believe this matches Firefox's behavior, which is also what I believe the discussion in #10201 leads to. Note that browsers have all different GC semantics (according to Claude): - Chromium makes a port uncollectable only if it's already started - Firefox does not collect them - WebKit keeps the port uncollectable only if it has a message listener Given that no browser ships the `close` events this revert is probably the best thing to do; if somebody in the future wants to reintroduce it some relevant discussions are: - #1766 - #9933 - #10201 - #12797 - #12957 Tests: web-platform-tests/wpt#63174 Closes #10201 and closes #12797.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See whatwg/html#13016 / whatwg/html#12957