Repository navigation
chore: release.sh gates on GitHub CI for the exact commit - #1631
Merged
Merged
Conversation
Today's release waited hours on a green local CI that kept failing on host-load timeouts while the same commit was green on GitHub CI, and the script also refused once main moved past the release commit. It now requires the CI workflow run for the exact sha to be green (the authoritative CI) and the commit to be on origin/main, runs the release gate on request (--gate), and no longer calls scripts/ci.sh, which #1630 removes. Claude-Session: https://claude.ai/code/session_01SZ72LSPAo4NvYvBDSD6RLo
|
Preview for Next: fix the listed keys in the compose file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release.sh now requires the CI workflow run for the exact release sha to be green on GitHub (the authoritative CI) and the commit to be an ancestor of origin/main (main may have moved on), runs
node scripts/release-gate.mjswith--gate, and no longer shells out to scripts/ci.sh or the PASS marker (removed by #1630). Today's 0.8.88/0.10.70 release was blocked for hours by local-CI load timeouts and by main moving past the release commit; it was published by running the script's steps on the GitHub-green commit, with the tag, npm wait, GitHub Releases and purge, local CI skipped for load with GitHub CI as the gate.https://claude.ai/code/session_01SZ72LSPAo4NvYvBDSD6RLo