Replace static_cast<> with C-style casts and fix real conversion warnings - #159
Draft
skal65535 wants to merge 2 commits into
Draft
Replace static_cast<> with C-style casts and fix real conversion warnings#159skal65535 wants to merge 2 commits into
skal65535 wants to merge 2 commits into
Conversation
…ings Converts all remaining static_cast<> numeric and pointer casts to C-style casts across src/, examples/, and tests/, matching the codebase's existing convention (reinterpret_cast/const_cast are left as-is). Also fixes the real precision-loss findings from -Wshorten-64-to-32 and -Wimplicit-(float|int-float)-conversion.
# Conflicts: # src/dichotomy.cc # src/enc.cc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts all remaining
static_cast<>numeric and pointer casts to C-style casts across src/, examples/, and tests/, matching the codebase's existing convention (reinterpret_cast/const_castare left as-is). Also fixes the real precision-loss findings from-Wshorten-64-to-32and-Wimplicit-(float|int-float)-conversion.