Skip to content

fix: allow sorting and mutating arrays due perf + bump lockfile #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evenstensberg merged 2 commits into from
Aug 30, 2026
Merged

fix: allow sorting and mutating arrays due perf + bump lockfile #434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c551d4c
fix: allow sorting and mutating arrays due perf
evenstensberg Aug 30, 2026
24d305f
chore: bump lockfile
evenstensberg Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,8 @@ import configs from "eslint-config-webpack/configs.js";
export default defineConfig([
{
extends: [configs["recommended-dirty"]],
rules: {
"unicorn/no-array-sort": "off",
},

@alexander-akait alexander-akait Aug 31, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not do it, we should fix it, eslint rules should be not suppressed, that they rules without the real problems

@evenstensberg evenstensberg Aug 31, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use toSorted instead but it will impact performance, so that's why this is a lint change instead

@alexander-akait alexander-akait Aug 31, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How it impacts performance?

@alexander-akait alexander-akait Aug 31, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use it in many places

@evenstensberg evenstensberg Aug 31, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toSorted created a copy instead of modifying/mutating the array, so more memory will be used.

https://dev.to/sundarbadagala081/sort-vs-tosorted-3gmi

@alexander-akait alexander-akait Aug 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it means we may have a potential problem/bug and code should be rewritten, never disable rules like because you want, each disabling should have a comment and why it was disabled, and where and how it should be resolve in future, it is very bad practice just disable

},
]);
48 changes: 12 additions & 36 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading