perf: reduce asset reporting and broadcast overhead - #5729
Conversation
🦋 Changeset detectedLatest commit: fc2f579 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. WalkthroughThe assets-report middleware calls Merge Risk: ⚪ Minimal · up to The performance changes preserve asset ordering, compiler handling, request method behavior, and broadcast semantics while reducing repeated work. Focused and existing tests pass, with no API or deployment change, so no actionable merge-blocking risk remains beyond normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 027f3a94-8e91-49f9-90f1-e47fa0af7f48
📒 Files selected for processing (2)
.changeset/server-reporting-overhead.mdlib/Server.js
Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review.
Improvements
Compatibility
No API, dependency, engine or intended output change. Empty/closed-only client sets still do no serialization. Asset order, compiler names and single/multi-compiler handling are retained.
Verification
Real webpack compilation with 31 emitted assets confirms complete report output and narrow stats options. Controls cover directory GET/HEAD and non-GET delegation, single/multiple/closed clients and serialization counts. Combined middleware/reporting/startup controls: 15 pass. Existing report, middleware and client/server tests pass in the frozen full run. Build and lint/type checks pass. No unsupported wall-clock speedup claim.
Audit scope
This is a focused, independently based change from a broader source review at f804962. The combined frozen-source run executed 1,002 tests: 951 passed, 43 failed, one cancelled, seven skipped. Failures were traced to the separately proposed overlay DOM snapshots, reconnect-disabled test expectation and IPv6 host-test assumptions; it is not represented as a green full suite. Relevant focused results are listed above. No checked-in tests/specs/snapshots were added or modified. Hosted CI and the full OS/Node matrix remain pending.
Summary by CodeRabbit